Skip to content

Commit 8bfb6f8

Browse files
committed
Added TODOs for docs
1 parent 218796e commit 8bfb6f8

File tree

14 files changed

+26
-1
lines changed

14 files changed

+26
-1
lines changed

docs/app/layout.config.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -95,6 +95,7 @@ export const baseOptions: Partial<DocsLayoutProps & HomeLayoutProps> = {
9595
sidebar: {
9696
tabs: [
9797
{
98+
// TODO: These icons are too small in the mobile view.
9899
icon: (
99100
<FaBook className="border-fd-primary text-fd-primary bg-fd-primary/10 h-5 w-5 rounded-sm border p-0.5" />
100101
),

docs/components/CustomDocsLayout.tsx

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -94,6 +94,8 @@ export function CustomDocsLayout({
9494
: undefined,
9595
);
9696

97+
// TODO: The scroll container for the sidebar is slightly too tall and gets cut off
98+
// at the bottom.
9799
const sidebar = sidebarComponent ?? (
98100
<>
99101
{sidebarCollapsible ? <CollapsibleControl /> : null}

docs/content/docs/features/blocks/embeds.mdx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,7 @@ type ImageBlock = {
3939
A file block is a block that displays a file.
4040

4141
**Type & Props**
42+
{/* TODO: Prop descriptions are missing. Also this should probably come before the image blocks. */}
4243

4344
```ts
4445
type FileBlock = {

docs/content/docs/features/blocks/list-types.mdx

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@ type BulletListItemBlock = {
3636
A numbered list item is a list item that is numbered.
3737

3838
**Type & Props**
39+
{/* TODO: We should add the `start` prop. */}
3940

4041
```typescript
4142
type NumberedListItemBlock = {
@@ -52,6 +53,7 @@ type NumberedListItemBlock = {
5253
A check list item is a list item that can be checked or unchecked.
5354

5455
**Type & Props**
56+
{/* TODO: We explain the heading block's `level` prop but don't explain the `checked` prop here. IMO they are both pretty self explanatory, so maybe we should either add an explanation here or remove it there. */}
5557

5658
```typescript
5759
type CheckListItemBlock = {

docs/content/docs/features/blocks/typography.mdx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ imageTitle: Typography
88

99
Typography blocks are fundamental elements for displaying text content in your documents. BlockNote supports various typography blocks to help you structure and format your content effectively.
1010

11+
{/* TODO: Not 100% sure if we want to include this demo for all subpages. */}
1112
<Example name="basic/default-blocks" />
1213

1314
## Paragraph

docs/content/docs/features/custom-schemas/custom-blocks.mdx

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,8 @@ type BlockConfig = {
5959
};
6060
```
6161

62+
{/* TODO: I think with the fumadocs styles, this looks a little wonky as the `type`, `content`, etc fields are not emphasized much. */}
63+
6264
**`type`**
6365

6466
Defines the identifier of the custom block.

docs/content/docs/foundations/document-structure.mdx

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,8 @@ The `content` field of a block contains the rich-text content of a block. This i
5454

5555
The `InlineContent` type is used to describe a piece of inline content:
5656

57+
{/* TODO: Technically there's also custom inline content which has its own type. Blocks share a type regardless of if they're custom or default, but inline content doesn't so this is potentially kind of misleading. */}
58+
5759
```typescript
5860
type Link = {
5961
type: "link";
@@ -76,6 +78,7 @@ The `styles` property is explained below.
7678

7779
The `styles` property of `StyledText` objects is used to describe the rich text styles (e.g.: bold, italic, color) or other attributes of a piece of text. It's a set of key / value pairs that specify the styles applied to the text.
7880

81+
{/* TODO: Wrong link. */}
7982
See the [Default Schema](/docs/foundations/schemas) to learn which styles are included in BlockNote by default.
8083

8184
## See it for yourself

docs/content/docs/foundations/manipulating-content.mdx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -131,6 +131,7 @@ editor.setSelection(startBlockId, endBlockId);
131131

132132
1. **Work with block references** - Use existing blocks as references for positioning new blocks
133133
2. **Handle errors gracefully** - Operations can fail if blocks don't exist or are invalid
134+
{/* TODO: This section reads really nicely, with the one caveat being that this page doesn't introduce transactions so the 3rd point is a bit out of nowhere. */}
134135
3. **Group related operations** - Use transactions to group multiple block changes into a single undo/redo operation
135136
4. **Consider user experience** - Think about how your block manipulations affect the user's workflow
136137

docs/content/docs/foundations/schemas.mdx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ Schemas are the core of how BlockNote works. They are the basic building blocks
1010

1111
The schema is a collection of definitions for the different types of blocks, inline content, and styles that can be used in the editor.
1212

13+
{/* TODO: I feel like this page has a lot of duplicated content with the Custom Schemas page. Maybe we should just link there instead? */}
1314
<Callout type="info">
1415
If you are using the default blocks, inline content, and styles, you do not
1516
need to specify a schema, since we use the default which uses the default

docs/content/docs/getting-started/editor-setup.mdx

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,8 @@ The hook takes two optional parameters:
3737

3838
**options:** Configure the editor with options like (see [Editor Options](/docs/reference/editor/overview#options) for all options):
3939

40+
{/* TODO: Might be more relevant to e.g. switch out `domAttributes` and `tabBehaviour` to `uploadFile` and `pasteHandler`. */}
41+
4042
- `initialContent` - Set starting content
4143
- `domAttributes` - Add HTML attributes to editor elements. See [Adding DOM Attributes](/docs/react/styling-theming/adding-dom-attributes) for more.
4244
- `dictionary` - Customize text strings for localization. See the [Localization](/docs/features/localization) for more.

0 commit comments

Comments
 (0)