fix: Attribute check in getDraggableBlockFromElement (#995)

matthewlipski · web-flow · commit 91d7a88a7ef6 · 2024-08-08T19:05:17.000+02:00
* Fixed attribute check in `getDraggableBlockFromElement`

* Removed old code
diff --git a/packages/core/src/extensions/SideMenu/SideMenuPlugin.ts b/packages/core/src/extensions/SideMenu/SideMenuPlugin.ts
@@ -33,11 +33,11 @@ export function getDraggableBlockFromElement(
     element &&
     element.parentElement &&
     element.parentElement !== view.dom &&
-    !element.hasAttribute?.("data-id")
+    element.getAttribute?.("data-node-type") !== "blockContainer"
   ) {
     element = element.parentElement;
   }
-  if (!element.hasAttribute("data-id")) {
+  if (element.getAttribute?.("data-node-type") !== "blockContainer") {
     return undefined;
   }
   return { node: element as HTMLElement, id: element.getAttribute("data-id")! };

Original file line number	Diff line number	Diff line change
`@@ -33,11 +33,11 @@ export function getDraggableBlockFromElement(`
`33`	`33`	`element &&`
`34`	`34`	`element.parentElement &&`
`35`	`35`	`element.parentElement !== view.dom &&`
`36`		`- !element.hasAttribute?.("data-id")`
	`36`	`+ element.getAttribute?.("data-node-type") !== "blockContainer"`
`37`	`37`	`) {`
`38`	`38`	`element = element.parentElement;`
`39`	`39`	`}`
`40`		`- if (!element.hasAttribute("data-id")) {`
	`40`	`+ if (element.getAttribute?.("data-node-type") !== "blockContainer") {`
`41`	`41`	`return undefined;`
`42`	`42`	`}`
`43`	`43`	`return { node: element as HTMLElement, id: element.getAttribute("data-id")! };`