Skip to content

Commit ac322a1

Browse files
fix: Suggestion menu positioning (#1975)
* Fixed suggestion menu positioning * Small fix * Small fix * Reverted pnpm lock * Updated pnpm lock
1 parent 4109efc commit ac322a1

File tree

4 files changed

+53
-8
lines changed

4 files changed

+53
-8
lines changed

packages/react/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@
6060
"dependencies": {
6161
"@blocknote/core": "0.37.0",
6262
"@emoji-mart/data": "^1.2.1",
63-
"@floating-ui/react": "^0.26.4",
63+
"@floating-ui/react": "^0.27.16",
6464
"@tiptap/core": "^2.26.1",
6565
"@tiptap/pm": "^2.26.1",
6666
"@tiptap/react": "^2.26.1",

packages/react/src/components/SuggestionMenu/SuggestionMenuController.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -123,6 +123,7 @@ export function SuggestionMenuController<
123123
apply({ availableHeight, elements }) {
124124
Object.assign(elements.floating.style, {
125125
maxHeight: `${availableHeight - 10}px`,
126+
minHeight: "300px",
126127
});
127128
},
128129
}),

packages/react/src/hooks/useUIElementPositioning.ts

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -51,10 +51,6 @@ export function useUIElementPositioning(
5151

5252
const { getReferenceProps, getFloatingProps } = useInteractions([dismiss]);
5353

54-
useEffect(() => {
55-
update();
56-
}, [referencePos, update]);
57-
5854
useEffect(() => {
5955
// Will be null on initial render when used in UI component controllers.
6056
if (referencePos === null) {
@@ -70,7 +66,9 @@ export function useUIElementPositioning(
7066
getBoundingClientRect: () => referencePos,
7167
});
7268
}
73-
}, [referencePos, refs]);
69+
70+
update();
71+
}, [referencePos, refs, update]);
7472

7573
return useMemo(() => {
7674
return {

pnpm-lock.yaml

Lines changed: 48 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)