Skip to content

Commit b74f6c7

Browse files
committed
Implemented PR feedback
1 parent aa51db8 commit b74f6c7

File tree

4 files changed

+3
-4
lines changed

4 files changed

+3
-4
lines changed

packages/core/src/schema/inlineContent/createSpec.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -223,7 +223,6 @@ export function createInlineContentSpec<
223223
inlineContentConfig.propSchema,
224224
{
225225
...inlineContentImplementation,
226-
runsBefore: inlineContentImplementation.runsBefore || ["default"],
227226
toExternalHTML: inlineContentImplementation.toExternalHTML,
228227
render(inlineContent, updateInlineContent, editor) {
229228
const output = inlineContentImplementation.render(

packages/core/src/schema/styles/createSpec.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,9 @@ export function getStyleParseRules<T extends StyleConfig>(
4747
if (customParseFunction) {
4848
rules.push({
4949
tag: "*",
50+
// By default, styles can overlap each other, so the rules should not
51+
// completely consume the element they parse (which can have multiple
52+
// styles).
5053
consuming: false,
5154
getAttrs(node: string | HTMLElement) {
5255
if (typeof node === "string") {
@@ -111,7 +114,6 @@ export function createStyleSpec<const T extends StyleConfig>(
111114
return createInternalStyleSpec(styleConfig, {
112115
...styleImplementation,
113116
mark,
114-
runsBefore: styleImplementation.runsBefore || ["default"],
115117
render: (value) => {
116118
const renderResult = styleImplementation.render(value as any);
117119

packages/react/src/schema/ReactInlineContentSpec.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -289,7 +289,6 @@ export function createReactInlineContentSpec<
289289
}, editor);
290290
return output;
291291
},
292-
runsBefore: inlineContentImplementation.runsBefore || ["default"]
293292
},
294293
) as any;
295294
}

packages/react/src/schema/ReactStyleSpec.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -169,6 +169,5 @@ export function createReactStyleSpec<T extends StyleConfig>(
169169
styleConfig.propSchema,
170170
);
171171
},
172-
runsBefore: styleImplementation.runsBefore || ["default"],
173172
});
174173
}

0 commit comments

Comments
 (0)