small fixes

Author: YousefED

packages/core/src/api/nodeConversions/blockToNode.ts

@@ -110,6 +110,7 @@ function linkToNodes(
  * prosemirror text nodes with the appropriate marks
  */
 function styledTextArrayToNodes<S extends StyleSchema>(
+  // this is lenient to "partial" inline content. FIXME: let's simplify and remove support for `string` here
   content: string | StyledText<S>[],
   schema: Schema,
   styleSchema: S,
@@ -144,6 +145,7 @@ export function inlineContentToNodes<
   I extends InlineContentSchema,
   S extends StyleSchema,
 >(
+  // this is lenient to "partial" inline content. FIXME: let's simplify and remove support for `string[]` here
   blockContent: string[] | InlineContent<I, S>[],
   schema: Schema,
   blockType?: string,
@@ -278,40 +280,34 @@ function blockOrInlineContentToContentNode(
   schema: Schema,
   styleSchema: StyleSchema,
 ) {
+  const type = block.type;
   let contentNode: Node;
-  let type = block.type;
-
-  // TODO: needed? came from previous code
-  if (type === undefined) {
-    // TODO: remove
-    type = "paragraph";
-  }
 
   if (!schema.nodes[type]) {
     throw new Error(`node type ${type} not found in schema`);
   }
 
   if (!block.content) {
-    contentNode = schema.nodes[type].createChecked(block.props as any);
+    contentNode = schema.nodes[type].createChecked(block.props);
   } else if (typeof block.content === "string") {
     const nodes = inlineContentToNodes(
       [block.content],
       schema,
       type,
       styleSchema,
     );
-    contentNode = schema.nodes[type].createChecked(block.props as any, nodes);
+    contentNode = schema.nodes[type].createChecked(block.props, nodes);
   } else if (Array.isArray(block.content)) {
     const nodes = inlineContentToNodes(
       block.content,
       schema,
       type,
       styleSchema,
     );
-    contentNode = schema.nodes[type].createChecked(block.props as any, nodes);
+    contentNode = schema.nodes[type].createChecked(block.props, nodes);
   } else if (block.content.type === "tableContent") {
     const nodes = tableContentToNodes(block.content, schema, styleSchema);
-    contentNode = schema.nodes[type].createChecked(block.props as any, nodes);
+    contentNode = schema.nodes[type].createChecked(block.props, nodes);
   } else {
     throw new UnreachableCaseError(block.content.type);
   }

packages/core/src/schema/partialBlockToBlock.ts

@@ -218,7 +218,7 @@ export function partialBlockToBlock<
 ): Block<BSchema, I, S> {
   const id = partialBlock.id || UniqueID.options.generateID();
 
-  // TODO
+  // Note: we might want to make "type" required for partial blocks and remove this default
   const type: string = partialBlock.type || "paragraph";
 
   const props = partialPropsToProps(