fix: remove tiptapblockimplementation

Author: nperez0111

packages/core/src/editor/CustomSchema.ts

@@ -23,7 +23,7 @@ function removeUndefined<T extends Record<string, any> | undefined>(obj: T): T {
 
 export type BlockSpecOf<BSpecs extends BlockSchema> = {
   [key in keyof BSpecs]: key extends string
-    ? BlockDefinition<key, PropSchema>
+    ? BlockDefinition<key, PropSchema, "inline" | "none" | "table">
     : never;
 };
 

packages/core/src/schema/blocks/createSpec.ts

@@ -294,7 +294,7 @@ export function createBlockSpec<
 
   return createInternalBlockSpec(blockConfig, {
     node,
-    toInternalHTML: (block, editor) => {
+    render: (block, editor) => {
       const blockContentDOMAttributes =
         node.options.domAttributes?.blockContent || {};
 

packages/core/src/schema/blocks/internal.ts

@@ -16,10 +16,10 @@ import { PropSchema, Props } from "../propTypes.js";
 import { StyleSchema } from "../styles/types.js";
 import {
   BlockConfig,
+  BlockDefinition,
+  BlockImplementation,
   BlockSchemaWithBlock,
-  BlockSpec,
   SpecificBlock,
-  TiptapBlockImplementation,
 } from "./types.js";
 
 // Function that uses the 'propSchema' of a blockConfig to create a TipTap
@@ -232,17 +232,15 @@ export function createStronglyTypedTiptapNode<
 // config and implementation that conform to the type of Config
 export function createInternalBlockSpec<T extends BlockConfig>(
   config: T,
-  implementation: TiptapBlockImplementation<
-    T,
-    any,
-    InlineContentSchema,
-    StyleSchema
-  >,
-) {
+  implementation: BlockImplementation<T["type"], PropSchema> & {
+    node: Node;
+    requiredExtensions?: Array<Extension | Node>;
+  },
+): BlockDefinition<T["type"], PropSchema> {
   return {
     config,
     implementation,
-  } satisfies BlockSpec<T, any, InlineContentSchema, StyleSchema>;
+  };
 }
 
 export function createBlockSpecFromStronglyTypedTiptapNode<
@@ -262,9 +260,8 @@ export function createBlockSpecFromStronglyTypedTiptapNode<
     {
       node,
       requiredExtensions,
-      toInternalHTML: defaultBlockToHTML,
+      render: defaultBlockToHTML,
       toExternalHTML: defaultBlockToHTML,
-      // parse: () => undefined, // parse rules are in node already
     },
   );
 }

packages/core/src/schema/blocks/types.ts

@@ -1,17 +1,16 @@
 /** Define the main block types **/
-import type { Extension, Node } from "@tiptap/core";
 
+import type { Fragment, Schema } from "prosemirror-model";
+import type { ViewMutationRecord } from "prosemirror-view";
 import type { BlockNoteEditor } from "../../editor/BlockNoteEditor.js";
+import type { BlockNoteExtension } from "../../editor/BlockNoteExtension.js";
 import type {
   InlineContent,
   InlineContentSchema,
   PartialInlineContent,
 } from "../inlineContent/types.js";
 import type { PropSchema, Props } from "../propTypes.js";
 import type { StyleSchema } from "../styles/types.js";
-import type { BlockNoteExtension } from "../../editor/BlockNoteExtension.js";
-import type { Fragment, Schema } from "prosemirror-model";
-import type { ViewMutationRecord } from "prosemirror-view";
 
 export type BlockNoteDOMElement =
   | "editor"
@@ -76,45 +75,10 @@ export interface BlockConfig<
   meta?: BlockConfigMeta;
 }
 
-// Block implementation contains the "implementation" info about a Block
-// such as the functions / Nodes required to render and / or serialize it
-export type TiptapBlockImplementation<
-  T extends BlockConfig,
-  B extends BlockSchema,
-  I extends InlineContentSchema,
-  S extends StyleSchema,
-> = {
-  requiredExtensions?: Array<Extension | Node>;
-  node: Node;
-  toInternalHTML: (
-    block: BlockFromConfigNoChildren<T, I, S> & {
-      children: BlockNoDefaults<B, I, S>[];
-    },
-    editor: BlockNoteEditor<B, I, S>,
-  ) => {
-    dom: HTMLElement;
-    contentDOM?: HTMLElement;
-  };
-  toExternalHTML: (
-    block: BlockFromConfigNoChildren<T, I, S> & {
-      children: BlockNoDefaults<B, I, S>[];
-    },
-    editor: BlockNoteEditor<B, I, S>,
-  ) => {
-    dom: HTMLElement;
-    contentDOM?: HTMLElement;
-  };
-};
-
 // A Spec contains both the Config and Implementation
-export type BlockSpec<
-  T extends BlockConfig,
-  B extends BlockSchema,
-  I extends InlineContentSchema,
-  S extends StyleSchema,
-> = {
+export type BlockSpec<T extends BlockConfig> = {
   config: T;
-  implementation: TiptapBlockImplementation<NoInfer<T>, B, I, S>;
+  implementation: BlockImplementation<NoInfer<T["type"]>, PropSchema>;
 };
 
 // Utility type. For a given object block schema, ensures that the key of each
@@ -133,14 +97,11 @@ type NamesMatch<Blocks extends Record<string, BlockConfig>> = Blocks extends {
 // The keys are the "type" of a block
 export type BlockSchema = NamesMatch<Record<string, BlockConfig>>;
 
-export type BlockSpecs = Record<
-  string,
-  BlockSpec<any, any, InlineContentSchema, StyleSchema>
->;
+export type BlockSpecs = Record<string, BlockSpec<any>>;
 
 export type BlockImplementations = Record<
   string,
-  TiptapBlockImplementation<any, any, any, any>
+  BlockImplementation<any, any>
 >;
 
 export type BlockSchemaFromSpecs<T extends BlockSpecs> = {