From 0c506fd3feed448087cc1d7e91cf427eaaeeff1f Mon Sep 17 00:00:00 2001 From: Brad Greenlee Date: Fri, 25 Jul 2025 17:45:10 -0700 Subject: [PATCH] Use image alt text for image block name This fixes the issue (#1882) where Markdown images that are converted to blocks and back again lose their alt text, having it replaced with the default alt text ("BlockNote image"). An alternative fix would be to use the alt text as the caption, but given that the caption is rendered as a separate element, that seemed less appropriate. --- .../core/src/blocks/ImageBlockContent/parseImageElement.ts | 3 ++- .../context/__snapshots__/ServerBlockNoteEditor.test.ts.snap | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/packages/core/src/blocks/ImageBlockContent/parseImageElement.ts b/packages/core/src/blocks/ImageBlockContent/parseImageElement.ts index d225b9daa3..21c0b31519 100644 --- a/packages/core/src/blocks/ImageBlockContent/parseImageElement.ts +++ b/packages/core/src/blocks/ImageBlockContent/parseImageElement.ts @@ -1,6 +1,7 @@ export const parseImageElement = (imageElement: HTMLImageElement) => { const url = imageElement.src || undefined; const previewWidth = imageElement.width || undefined; + const name = imageElement.alt || undefined; - return { url, previewWidth }; + return { url, previewWidth, name }; }; diff --git a/packages/server-util/src/context/__snapshots__/ServerBlockNoteEditor.test.ts.snap b/packages/server-util/src/context/__snapshots__/ServerBlockNoteEditor.test.ts.snap index f2522c662a..4e320edf15 100644 --- a/packages/server-util/src/context/__snapshots__/ServerBlockNoteEditor.test.ts.snap +++ b/packages/server-util/src/context/__snapshots__/ServerBlockNoteEditor.test.ts.snap @@ -217,7 +217,7 @@ exports[`Test ServerBlockNoteEditor > converts to and from markdown (blocksToMar "props": { "backgroundColor": "default", "caption": "", - "name": "", + "name": "Example", "showPreview": true, "textAlignment": "left", "url": "exampleURL",