feat: Mantine v8 upgrade #2028
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -10,7 +10,7 @@ | |
| "Custom Schemas" | ||
| ], | ||
| "dependencies": { | ||
| "@mantine/core": "^8.3.1", | ||
| "react-icons": "^5.2.1" | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -10,7 +10,7 @@ | |
| "Slash Menu" | ||
| ], | ||
| "dependencies": { | ||
| "@mantine/core": "^8.3.1", | ||
| "react-icons": "^5.2.1" | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -10,7 +10,7 @@ | |
| "Slash Menu" | ||
| ], | ||
| "dependencies": { | ||
| "@mantine/core": "^8.3.1", | ||
| "react-icons": "^5.2.1" | ||
| }, | ||
| "pro": true | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -11,7 +11,7 @@ | |
| "Slash Menu" | ||
| ], | ||
| "dependencies": { | ||
| "@mantine/core": "^8.3.1", | ||
| "react-icons": "^5.2.1" | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -82,62 +82,46 @@ | |
| @import url("@mantine/core/styles/Timeline.css"); | ||
| @import url("@mantine/core/styles/Title.css"); | ||
| @import url("@mantine/core/styles/Tooltip.css"); | ||
| @import url("@mantine/core/styles/Typography.css"); | ||
|
|
||
| /* Mantine baseline styles, scoped to .bn-mantine element. */ | ||
|
Collaborator
There was a problem hiding this comment. are you sure we don't need the other styles from global.css?
Collaborator
Author
There was a problem hiding this comment. Yes, the Default focus style: Mantine global focus style: The other styles in |
||
| /* https://github.com/mantinedev/mantine/blob/7.17.8/packages/%40mantine/core/src/core/MantineProvider/baseline.css */ | ||
matthewlipski marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| .bn-mantine { | ||
| color-scheme: var(--mantine-color-scheme); | ||
| } | ||
|
|
||
| .bn-mantine *, | ||
| .bn-mantine *::before, | ||
| .bn-mantine *::after { | ||
| box-sizing: border-box; | ||
| } | ||
|
|
||
| /* .bn-mantine input, | ||
| .bn-mantine button, | ||
| .bn-mantine textarea, | ||
| .bn-mantine select { | ||
| font: inherit; | ||
| } */ | ||
|
|
||
| .bn-mantine button, | ||
| .bn-mantine select { | ||
| text-transform: none; | ||
| } | ||
|
|
||
| .bn-mantine { | ||
| /* margin: 0; | ||
matthewlipski marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| font-family: var(--mantine-font-family); | ||
| font-size: var(--mantine-font-size-md); | ||
| line-height: var(--mantine-line-height); | ||
| background-color: var(--mantine-color-body); | ||
| color: var(--mantine-color-text); */ | ||
|
|
||
| -webkit-font-smoothing: var(--mantine-webkit-font-smoothing); | ||
| -moz-osx-font-smoothing: var(--mantine-moz-font-smoothing); | ||
| } | ||
|
|
||
| @media screen and (max-device-width: em(500px)) { | ||
| .bn-mantine { | ||
| -webkit-text-size-adjust: 100%; | ||
| } | ||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you need to update the .bnblock config file or whatever it is called. So that pnpm run gen doesn't overwrite these changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it not correct as is? In the
.bnexample.jsonfile, I updated the Mantine package version underdependencies, whichpnpm genuses to update the dependencies in the correspondingpackage.json. Or am I misunderstanding?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah maybe I missed it then