Skip to content

Commit 572776e

Browse files
authored
Lerna cache (#300)
* add lerna cache * switch to wait-on * fix lerna cache * cache playwright * fix pw install * disable ineffective ci
1 parent d656aa6 commit 572776e

File tree

2 files changed

+18
-7
lines changed

2 files changed

+18
-7
lines changed

.github/workflows/build.yaml

Lines changed: 17 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,22 @@ jobs:
1414
with:
1515
node-version: 16.x
1616

17+
# doesn't seem to cause significant speed up, probably because it still needs to install deps
18+
# - name: cache playwright
19+
# uses: actions/cache@v2
20+
# with:
21+
# path: ~/.cache/ms-playwright
22+
# key: pw-${{ runner.os }}-${{ hashFiles('**/package-lock.json') }}
23+
24+
# doesn't seem to cause significant speed up, maybe not right conf?
25+
# - name: cache lerna
26+
# uses: actions/cache@v2
27+
# with:
28+
# path: |
29+
# node_modules
30+
# packages/**/node_modules
31+
# key: lerna-${{ runner.os }}-${{ hashFiles('**/package-lock.json') }}
32+
1733
- name: Cache node modules
1834
uses: actions/cache@v2
1935
env:
@@ -46,12 +62,7 @@ jobs:
4662
run: npm run bootstrap
4763

4864
- name: Wait for Matrix
49-
uses: nev7n/wait_for_response@v1
50-
with:
51-
url: "http://localhost:8888/_matrix/static/"
52-
responseCode: 200
53-
timeout: 20000
54-
interval: 500
65+
run: npx wait-on http://localhost:8888/_matrix/static/
5566

5667
- name: Build packages
5768
run: npm run build

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
"bootstrap": "lerna bootstrap --hoist --ci && patch-package",
1616
"install-new-packages": "lerna bootstrap --hoist && patch-package",
1717
"playwright": "lerna run playwright",
18-
"install-playwright": "lerna run install-playwright",
18+
"install-playwright": "npx playwright install --with-deps",
1919
"test": "jest --coverage=true --config=jest.config.js && lerna run test-no-watch",
2020
"build": "lerna run build --concurrency 1",
2121
"build-react": "lerna run build-react --concurrency 1 --stream",

0 commit comments

Comments
 (0)