remove pings, fix input view types (#322)

Author: YousefED

packages/editor/src/runtime/executor/executionHosts/sandboxed/SandboxedExecutionHost.tsx

@@ -293,7 +293,7 @@ export default class SandboxedExecutionHost
 
   private async pingFrame() {
     const result = await this.connectionMethods!.ping();
-    console.log("received ping result", result);
+    // console.log("received ping result", result);
     if (result !== "pong") {
       throw new Error("invalid ping response");
     }

packages/editor/src/runtime/executor/executionHosts/sandboxed/iframesandbox/FrameConnection.ts

@@ -3,13 +3,13 @@ import { observable, runInAction } from "mobx";
 import { AsyncMethodReturns, Connection, connectToParent } from "penpal";
 import { lifecycle } from "vscode-lib";
 import { CompiledCodeModel } from "../../../../../models/CompiledCodeModel";
-import { getTypeCellResolver } from "../../../resolver/resolver";
 import { ModelOutput } from "../../../components/ModelOutput";
+import { getTypeCellResolver } from "../../../resolver/resolver";
 
-import { ModelReceiver } from "./ModelReceiver";
 import type { VisualizersByPath } from "../../../../extensions/visualizer/VisualizerExtension";
-import { IframeBridgeMethods } from "./IframeBridgeMethods";
 import { HostBridgeMethods } from "../HostBridgeMethods";
+import { IframeBridgeMethods } from "./IframeBridgeMethods";
+import { ModelReceiver } from "./ModelReceiver";
 
 let ENGINE_ID = 0;
 
@@ -224,7 +224,7 @@ export class FrameConnection extends lifecycle.Disposable {
       });
     },
     ping: async () => {
-      console.log("ping received, sending pong");
+      // console.log("ping received, sending pong");
       return "pong";
     },
 

packages/editor/src/runtime/executor/lib/exports.ts

@@ -9,7 +9,7 @@ export default function getExposeGlobalVariables(id: string) {
   return {
     // routing,
     // // DocumentView,
-    Input: Input as any, // TODO
+    Input,
     // namespace: id, // TODO: naming
     // open: (identifier: string | { owner: string; document: string }) => {
     //   return DocConnection.load(identifier);

packages/editor/src/runtime/executor/lib/input/Input.tsx

@@ -1,30 +1,38 @@
+import { getReactViewValue } from "@typecell-org/engine";
 import { IObservableValue, isObservable, observable } from "mobx";
 import * as React from "react";
-import { getReactViewValue, ReactView } from "@typecell-org/engine";
 import ReactViewElement from "./ReactViewElement";
 
+// same as ReactView from typecell-org/engine, but define here so we don't import all types at runtime
+type TypeCellView<T> = React.ReactElement<{
+  __tcObservable: T;
+}>;
+
+type TextAreaType = React.ReactElement<
+  React.DetailedHTMLProps<
+    React.TextareaHTMLAttributes<HTMLTextAreaElement>,
+    HTMLTextAreaElement
+  >
+>;
+
+type SelectType = React.ReactElement<
+  React.DetailedHTMLProps<
+    React.SelectHTMLAttributes<HTMLSelectElement>,
+    HTMLSelectElement
+  >
+>;
+
+type InputType = React.ReactElement<
+  React.DetailedHTMLProps<
+    React.InputHTMLAttributes<HTMLInputElement>,
+    HTMLInputElement
+  >
+>;
+
 export function Input<T extends string | string[] | number = string>(
-  el:
-    | React.ReactElement<
-        React.DetailedHTMLProps<
-          React.InputHTMLAttributes<HTMLInputElement>,
-          HTMLInputElement
-        >
-      >
-    | React.ReactElement<
-        React.DetailedHTMLProps<
-          React.TextareaHTMLAttributes<HTMLTextAreaElement>,
-          HTMLTextAreaElement
-        >
-      >
-    | React.ReactElement<
-        React.DetailedHTMLProps<
-          React.SelectHTMLAttributes<HTMLSelectElement>,
-          HTMLSelectElement
-        >
-      >,
-  bindingOrDefaultValue?: T | ReactView<T>
-): ReactView<T extends string ? string : T> {
+  el: TextAreaType | SelectType | InputType,
+  bindingOrDefaultValue?: T | TypeCellView<T>
+): TypeCellView<T extends string ? string : T> {
   // don't use string literals
   if (el.type !== "input" && el.type !== "select" && el.type !== "textarea") {
     throw new Error("invalid element passed");