fix bug

Author: YousefED

packages/editor/src/models/TypeCellCodeModel.ts

@@ -78,7 +78,8 @@ export class TypeCellCodeModel extends lifecycle.Disposable {
 
   private disposeMonacoModel() {
     if (this.monacoModelReferences > 0) {
-      throw new Error("disposing TypeCellCodeModel, but still has references");
+      // This is suspicious, happens when compiling code and releasing at same time?
+      console.error("disposing TypeCellCodeModel, but still has references");
     }
 
     if (

packages/editor/src/runtime/compiler/compilers/MonacoCompiler.ts

@@ -121,21 +121,24 @@ async function _compile(
   }
 
   console.log("recompile", model.path);
-  const monacoModel = model.acquireMonacoModel();
 
-  if (!mainWorker) {
-    mainWorker =
-      await monacoInstance.languages.typescript.getTypeScriptWorker();
-  }
+  const monacoModel = model.acquireMonacoModel();
+  try {
+    if (!mainWorker) {
+      mainWorker =
+        await monacoInstance.languages.typescript.getTypeScriptWorker();
+    }
 
-  let compiledCode = (await getCompiledCode(mainWorker, monacoModel.uri))
-    .firstJSCode;
-  model.releaseMonacoModel();
-  if (ENABLE_CACHE) {
-    saveCachedItem(model, { hash: hsh, compiledCode });
+    let compiledCode = (await getCompiledCode(mainWorker, monacoModel.uri))
+      .firstJSCode;
+    if (ENABLE_CACHE) {
+      saveCachedItem(model, { hash: hsh, compiledCode });
+    }
+    // console.log(tscode, compiledCode);
+    return compiledCode;
+  } finally {
+    model.releaseMonacoModel();
   }
-  // console.log(tscode, compiledCode);
-  return compiledCode;
 }
 
 export const compile = awaitFirst(_compile);