Yarn problems / use MEW and real vscode extension code in same workspace

[cdietrich]

Hi, i finally can reproduce my yarn problem in a simple example
here is the repo

https://github.com/cdietrich/yarn-monaco-languageclient-problem

• branch main: before the update
• branch cd-update: after the update

as you can see from the history, with a reduced set of deps in projectb it was not reproducible

the error

../../node_modules/vscode/extension.api.d.ts:1:18 - error TS2303: Circular definition of import alias 'vscode'.

1 import type * as vscode from "vscode";
                   ~~~~~~


Found 1 error in ../../node_modules/vscode/extension.api.d.ts:1

is different but i am keep looking

(in my original i am getting)

src/extension.ts:3:1 - error TS6133: 'vscode' is declared but its value is never read.

3 import * as vscode from 'vscode';
  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

src/extension.ts:16:42 - error TS2503: Cannot find namespace 'vscode'.

16 export async function activate(_context: vscode.ExtensionContext): Promise<void> {}
                                            ~~~~~~

i also see it in the peerNpm verify project when changing the file to

/* --------------------------------------------------------------------------------------------
 * Copyright (c) 2024 TypeFox and others.
 * Licensed under the MIT License. See License.txt in the project root for license information.
 * ------------------------------------------------------------------------------------------ */

import * as vscode from 'vscode';
import type { LanguageClient } from "vscode-languageclient/node.js"


console.log(vscode.workspace.name);



let client: LanguageClient | undefined

// This function is called when the extension is deactivated.
export function deactivate(): Thenable<void> | undefined {
  if (client !== undefined) {
    return client.stop()
  }
  return undefined
}

// This function is called when the extension is activated.
export async function activate(_context: vscode.ExtensionContext): Promise<void> {}

let uri = vscode.Uri.file('file:///path/to/file');
console.log(uri)

with previous version

 "dependencies": {
   "monaco-editor": "npm:@codingame/monaco-vscode-editor-api@~11.1.2",
    "monaco-editor-wrapper": "~6.1.1",
    "monaco-languageclient": "~9.1.1",
    "vscode": "npm:@codingame/monaco-vscode-api@~11.1.2"
  },

it was working

does work: https://github.com/cdietrich/monaco-languageclient/pull/new/cd-does-work
doesnt work: https://github.com/cdietrich/monaco-languageclient/pull/new/cd-does-not-work

[kaisalmen]

@cdietrich thank you. I will have a look, maybe over the weekend.

[kaisalmen]

@CGNonofr I reproduced what @cdietrich provided locally (just his code ⬆️ on current main) and something is not right here. The package offers exports that do not exist in the package. I hope that I captured everything necessary in one screenshot. I also tried to import ExtensionContext from somewhere else, but it wasn't able to find it:

These are the dependencies of the the project peerNpm after npm install.

@typefox/[email protected] O:\monaco\monaco-languageclient\verify\peerNpm
├─┬ [email protected]
│ ├── @codingame/[email protected]
│ ├── @codingame/[email protected]
│ ├── @codingame/[email protected]
│ ├── @codingame/[email protected]
│ ├── @codingame/[email protected]
│ ├── @codingame/[email protected]
│ ├── @codingame/[email protected]
│ ├── @codingame/[email protected]
│ ├── @codingame/[email protected]
│ ├── @codingame/[email protected]
│ ├── [email protected]
│ └── vscode@npm:@codingame/[email protected] deduped
├── [email protected]
└─┬ vscode@npm:@codingame/[email protected]
  ├── @codingame/[email protected]
  ├── @codingame/[email protected] deduped
  ├── @codingame/[email protected]
  └── @codingame/[email protected] deduped

[CGNonofr]

import "@codingame/monaco-vscode-api/vscode-dts/vscode"
import type * as vscode from "vscode";

is very probably better though, as it doesn't really make sense to import something from @codingame/monaco-vscode-api/vscode-dts/vscode which only declares a module

changed in CodinGame/monaco-vscode-api@3f8369a

[kaisalmen]

@CGNonofr thank you. 👍 I will review CodinGame/monaco-vscode-api#577 later

[kaisalmen]

@cdietrich thank you for spotting this.

[cdietrich]

with 6.3.0 looks much better now. still need to do some extensive testing.
specially which service override deps we actually need

monaco-languageclient/packages/examples/package.json

Line 74 in ea57ad8

"@codingame/monaco-vscode-configuration-service-override": "~14.0.2",

is a quite big list

[cdietrich]

last problem to solve:

jest.mock("vscode", () => ({ does no longer work

  ● Test suite failed to run

    The error below may be caused by using the wrong test environment, see https://jestjs.io/docs/configuration#testenvironment-string.
    Consider using the "jsdom" test environment.
    
    ReferenceError: window is not defined

      at ../../node_modules/@codingame/monaco-vscode-api/vscode/src/vs/base/browser/window.js:11:20

[kaisalmen]

@cdietrich interesting, this really worked before?

The only stable test environment without hacks/pseudo DOMs (like jsdom) is vitest browser mode + playright or webdriverio wheres the former works best now. Nothing else I tried was working properly.

[kaisalmen]

I guess the import brings more code/dependencies now which leads to the error you observed

[cdietrich]

Yes the mocking worked before and now no longer does