chore(tsconfig) filesGlob cleanup

closes #648

Author: basarat

dist/main/tsconfig/tsconfig.js

@@ -67,11 +67,11 @@ var os = require('os');
 var formatting = require('./formatting');
 var projectFileName = 'tsconfig.json';
 var defaultFilesGlob = [
-    "./**/*.ts",
-    "./**/*.tsx",
-    "!./node_modules/**/*",
+    "**/*.ts",
+    "**/*.tsx",
+    "!node_modules/**",
 ];
-var invisibleFilesGlob = ["./**/*.ts", "./**/*.tsx"];
+var invisibleFilesGlob = ["**/*.ts", "**/*.tsx"];
 exports.defaults = {
     target: ts.ScriptTarget.ES5,
     module: ts.ModuleKind.CommonJS,
@@ -217,7 +217,7 @@ function getProjectSync(pathOrSrcFile) {
     if (!projectSpec.files && !projectSpec.filesGlob) {
         var toExpand = invisibleFilesGlob;
         if (projectSpec.exclude) {
-            toExpand = toExpand.concat(projectSpec.exclude.map(function (exclude) { return '!' + exclude; }));
+            toExpand = toExpand.concat(projectSpec.exclude.map(function (exclude) { return ("!" + exclude + "/**"); }));
         }
     }
     if (projectSpec.filesGlob) {

docs/faq.md

@@ -3,8 +3,23 @@
 ## I keep getting changes to tsconfig.json
 This is probably because of us keeping `files` updated with the `filesGlob` option. The reason why we do this is because the official `tsconfig.json` spec does not support `filesGlob`. Therefore we keep `files` in sync with the `filesGlob` so that your team mates can use whatever editor they prefer (sublime text, visual studio etc.).
 
+## For really large projects atom-typescript gets slow
+If you have `tsconfig.json` in a folder that contains `node_modules`, atom-typescript might become slow (due to extensive file listing). Two possible fixes:
+* Move `tsconfig.json` into a sub folder e.g. `src`
+* Add a `filesGlob` that excludes `node_modules` e.g.:
+
+```ts
+"filesGlob" : [
+    "**/*.ts",
+    "**/*.tsx",
+    "!node_modules/**",
+];
+```
+
+[Further Details](https://github.com/TypeStrong/atom-typescript/issues/648).
+
 ## I don't want atom-typescript compiling my js
-Set `compileOnSave : false` in your tsconfig.json (https://github.com/TypeStrong/atom-typescript/blob/master/docs/tsconfig.md#compileonsave).  Then you've got all the intellisense / refactoring goodness of atom-typescript but no generated JavaScript.  Why is this useful?  Well you might be using something else for your build such as [gulp-typescript](https://github.com/ivogabe/gulp-typescript) or [tsify](https://github.com/smrq/tsify).
+Set `compileOnSave : false` in your tsconfig.json (https://github.com/TypeStrong/atom-typescript/blob/master/docs/tsconfig.md#compileonsave).  Then you've got all the intellisense / refactoring goodness of atom-typescript but no generated JavaScript.  Why is this useful?  Well you might be using something else for your build such as [ts-loader](https://github.com/TypeStrong/ts-loader) or [tsify](https://github.com/TypeStrong/tsify) or [gulp-typescript](https://github.com/ivogabe/gulp-typescript).
 
 ## Which version of TypeScript does atom-typescript use?
 It uses [ntypescript](https://github.com/TypeStrong/ntypescript) which is just a build of Microsoft/Master.  This means it's the latest and greatest of the TypeScript goodness.  There is a possibility that in the future it will move to TypeScript nightlies but our current automation is working well.

lib/main/tsconfig/tsconfig.ts

@@ -205,14 +205,14 @@ var projectFileName = 'tsconfig.json';
  * This is what we write to new files
  */
 var defaultFilesGlob = [
-    "./**/*.ts",
-    "./**/*.tsx",
-    "!./node_modules/**/*",
+    "**/*.ts",
+    "**/*.tsx",
+    "!node_modules/**",
 ];
 /**
  * This is what we use when the user doens't specify a files / filesGlob
  */
-var invisibleFilesGlob = ["./**/*.ts", "./**/*.tsx"];
+var invisibleFilesGlob = ["**/*.ts", "**/*.tsx"];
 
 export var defaults: ts.CompilerOptions = {
     target: ts.ScriptTarget.ES5,
@@ -293,7 +293,7 @@ function rawToTsCompilerOptions(jsonOptions: CompilerOptions, projectDir: string
     if (compilerOptions.out !== undefined) {
         compilerOptions.out = path.resolve(projectDir, compilerOptions.out);
     }
-    
+
     if (compilerOptions.outFile !== undefined) {
         // Till out is removed. Support outFile by just copying it to `out`
         compilerOptions.out = path.resolve(projectDir, compilerOptions.outFile);
@@ -393,7 +393,7 @@ export function getProjectSync(pathOrSrcFile: string): TypeScriptProjectFileDeta
     if (!projectSpec.files && !projectSpec.filesGlob) { // If there is no files and no filesGlob, we create an invisible one.
         var toExpand = invisibleFilesGlob;
         if(projectSpec.exclude){
-            toExpand = toExpand.concat(projectSpec.exclude.map((exclude) => '!' + exclude));
+            toExpand = toExpand.concat(projectSpec.exclude.map((exclude) => `!${exclude}/**`));
         }
     }
     if (projectSpec.filesGlob) { // If there is a files glob we will use that

snippets/tsconfig-snippets.cson

@@ -3,8 +3,8 @@
         'prefix': 'fg'
         'body': """
             "filesGlob": [
-                "./**/*.ts",
-                "./**/*.tsx",
-                "!./node_modules/**/*.ts"
+                "**/*.ts",
+                "**/*.tsx",
+                "!node_modules/**"
             ],
         """