Merge pull request #644 from ealves-pt/jumpy-bottom-bar

basarat · basarat · commit 8c9c8a263c6d · 2015-10-07T10:56:30.000+11:00
"Jumpy" Bottom Bar - fadeOut/fadeIn replaced by animate
diff --git a/dist/main/atom/views/mainPanelView.js b/dist/main/atom/views/mainPanelView.js
@@ -209,10 +209,10 @@ var MainPanelView = (function (_super) {
         this.txtPendingCount.html("<span class=\"text-highlight\">" + this.pendingRequests.length + "</span>");
         this.sectionPending.stop();
         if (pending.length) {
-            this.sectionPending.fadeIn(500);
+            this.sectionPending.animate({ opacity: 0.5 }, 500);
         }
         else {
-            this.sectionPending.fadeOut(200);
+            this.sectionPending.animate({ opacity: 0 }, 200);
         }
     };
     MainPanelView.prototype.errorPanelSelectedClick = function () {
diff --git a/lib/main/atom/views/mainPanelView.ts b/lib/main/atom/views/mainPanelView.ts
@@ -241,10 +241,10 @@ export class MainPanelView extends view.View<any> {
 
         this.sectionPending.stop();
         if (pending.length) {
-            this.sectionPending.fadeIn(500);
+            this.sectionPending.animate({opacity: 0.5}, 500);
         }
         else {
-            this.sectionPending.fadeOut(200);
+            this.sectionPending.animate({opacity: 0}, 200);
         }
     }
 

Original file line number	Diff line number	Diff line change
`@@ -209,10 +209,10 @@ var MainPanelView = (function (_super) {`
`209`	`209`	`this.txtPendingCount.html("<span class=\"text-highlight\">" + this.pendingRequests.length + "</span>");`
`210`	`210`	`this.sectionPending.stop();`
`211`	`211`	`if (pending.length) {`
`212`		`- this.sectionPending.fadeIn(500);`
	`212`	`+ this.sectionPending.animate({ opacity: 0.5 }, 500);`
`213`	`213`	`}`
`214`	`214`	`else {`
`215`		`- this.sectionPending.fadeOut(200);`
	`215`	`+ this.sectionPending.animate({ opacity: 0 }, 200);`
`216`	`216`	`}`
`217`	`217`	`};`
`218`	`218`	`MainPanelView.prototype.errorPanelSelectedClick = function () {`
Original file line number	Diff line number	Diff line change
`@@ -241,10 +241,10 @@ export class MainPanelView extends view.View<any> {`
`241`	`241`
`242`	`242`	`this.sectionPending.stop();`
`243`	`243`	`if (pending.length) {`
`244`		`- this.sectionPending.fadeIn(500);`
	`244`	`+ this.sectionPending.animate({opacity: 0.5}, 500);`
`245`	`245`	`}`
`246`	`246`	`else {`
`247`		`- this.sectionPending.fadeOut(200);`
	`247`	`+ this.sectionPending.animate({opacity: 0}, 200);`
`248`	`248`	`}`
`249`	`249`	`}`
`250`	`250`