fix useTypescriptIncrementalApi flag to work according to docs (#223)

* fix useTypescriptIncrementalApi

* do not default to using incremental watch API in Vue mode

* update changelog and bump version

Author: yanivefraim

CHANGELOG.md

@@ -1,3 +1,7 @@
+## v1.0.0-alpha.10
+
+* [Fix incremental api to work with TS 3+ by default](https://github.com/Realytics/fork-ts-checker-webpack-plugin/pull/223)
+
 ## v1.0.0-alpha.9
 
 * [Default to incremental api usage to true if TS 3+](https://github.com/Realytics/fork-ts-checker-webpack-plugin/pull/217)

package.json

@@ -1,6 +1,6 @@
 {
   "name": "fork-ts-checker-webpack-plugin",
-  "version": "1.0.0-alpha.9",
+  "version": "1.0.0-alpha.10",
   "description": "Runs typescript type checker and linter on separate process.",
   "main": "lib/index.js",
   "types": "lib/index.d.ts",

src/index.ts

@@ -205,12 +205,13 @@ class ForkTsCheckerWebpackPlugin {
 
     this.validateVersions();
 
+    this.vue = options.vue === true; // default false
+
     this.useTypescriptIncrementalApi =
       options.useTypescriptIncrementalApi === undefined
-        ? semver.gte(this.typescriptVersion, '3.0.0')
+        ? semver.gte(this.typescriptVersion, '3.0.0') && !this.vue
         : options.useTypescriptIncrementalApi;
 
-    this.vue = options.vue === true; // default false
     this.measureTime = options.measureCompilationTime === true;
     if (this.measureTime) {
       // Node 8+ only
@@ -571,8 +572,7 @@ class ForkTsCheckerWebpackPlugin {
           WORK_DIVISION: Math.max(1, this.workersNumber),
           MEMORY_LIMIT: this.memoryLimit,
           CHECK_SYNTACTIC_ERRORS: this.checkSyntacticErrors,
-          USE_INCREMENTAL_API:
-            this.options.useTypescriptIncrementalApi === true,
+          USE_INCREMENTAL_API: this.useTypescriptIncrementalApi === true,
           VUE: this.vue
         },
         stdio: ['inherit', 'inherit', 'inherit', 'ipc']

test/unit/index.spec.js

@@ -118,5 +118,25 @@ describe('[UNIT] ForkTsCheckerWebpackPlugin', function() {
       expect(new ForkTsCheckerWebpackPlugin().useTypescriptIncrementalApi).to.be
         .true;
     });
+
+    it('should be false if useTypescriptIncrementalApi not supplied and typescript version < 3.0.0 and vue is true', function() {
+      mockRequire('typescript', { version: '2.1.0' });
+      var ForkTsCheckerWebpackPlugin = mockRequire.reRequire('../../lib/index');
+
+      expect(
+        new ForkTsCheckerWebpackPlugin({ vue: true })
+          .useTypescriptIncrementalApi
+      ).to.be.false;
+    });
+
+    it('should be false if useTypescriptIncrementalApi not supplied and typescript version >= 3.0.0 and vue is true', function() {
+      mockRequire('typescript', { version: '3.0.0' });
+      var ForkTsCheckerWebpackPlugin = mockRequire.reRequire('../../lib/index');
+
+      expect(
+        new ForkTsCheckerWebpackPlugin({ vue: true })
+          .useTypescriptIncrementalApi
+      ).to.be.false;
+    });
   });
 });

yarn.lock

@@ -3691,8 +3691,9 @@ typedarray@^0.0.6:
   resolved "https://registry.yarnpkg.com/typedarray/-/typedarray-0.0.6.tgz#867ac74e3864187b1d3d47d996a78ec5c8830777"
 
 typescript@^3.0.1:
-  version "3.2.2"
-  resolved "https://registry.yarnpkg.com/typescript/-/typescript-3.2.2.tgz#fe8101c46aa123f8353523ebdcf5730c2ae493e5"
+  version "3.3.3333"
+  resolved "https://registry.yarnpkg.com/typescript/-/typescript-3.3.3333.tgz#171b2c5af66c59e9431199117a3bcadc66fdcfd6"
+  integrity sha512-JjSKsAfuHBE/fB2oZ8NxtRTk5iGcg6hkYXMnZ3Wc+b2RSqejEqTaem11mHASMnFilHrax3sLK0GDzcJrekZYLw==
 
 uglify-js@^3.1.4:
   version "3.4.9"