refactor: rename files to match convention (#693)

I found snake-case easier to read, and given that
the project doesn't use OOP a lot, having all PascalCase
names doesn't reflect the paradigm and feels unnatural.

Author: piotr-oles

README.md

@@ -139,7 +139,7 @@ type IssueFilter = IssueMatch | IssuePredicate | (IssueMatch | IssuePredicate)[]
 
 | Name      | Type          | Default value | Description |
 | --------- | ------------- | ------------- | ----------- |
-| `include` | `IssueFilter` | `undefined`   | If `object`, defines issue properties that should be [matched](./src/issue/IssueMatch.ts). If `function`, acts as a predicate where `issue` is an argument. |
+| `include` | `IssueFilter` | `undefined`   | If `object`, defines issue properties that should be [matched](src/issue/issue-match.ts). If `function`, acts as a predicate where `issue` is an argument. |
 | `exclude` | `IssueFilter` | `undefined`   | Same as `include` but issues that match this predicate will be excluded. |
 
 <details>

release.config.js

@@ -32,8 +32,7 @@ module.exports = {
     [
       '@semantic-release/exec',
       {
-        prepareCmd:
-          "sed -i 's/{{VERSION}}/${nextRelease.version}/g' lib/ForkTsCheckerWebpackPlugin.js",
+        prepareCmd: "sed -i 's/{{VERSION}}/${nextRelease.version}/g' lib/plugin.js",
       },
     ],
   ],

src/ForkTsCheckerWebpackPluginConfiguration.ts

@@ -1,8 +1,5 @@
 import type * as webpack from 'webpack';
 
-import subtract from './utils/array/substract';
-import unique from './utils/array/unique';
-
 interface FilesChange {
   changedFiles?: string[];
   deletedFiles?: string[];
@@ -14,6 +11,12 @@ function getFilesChange(compiler: webpack.Compiler): FilesChange {
   return compilerFilesChangeMap.get(compiler) || { changedFiles: [], deletedFiles: [] };
 }
 
+function consumeFilesChange(compiler: webpack.Compiler): FilesChange {
+  const change = getFilesChange(compiler);
+  clearFilesChange(compiler);
+  return change;
+}
+
 function updateFilesChange(compiler: webpack.Compiler, change: FilesChange): void {
   compilerFilesChangeMap.set(compiler, aggregateFilesChanges([getFilesChange(compiler), change]));
 }
@@ -29,22 +32,31 @@ function clearFilesChange(compiler: webpack.Compiler): void {
  * @returns Files change that represents all subsequent changes as a one event
  */
 function aggregateFilesChanges(changes: FilesChange[]): FilesChange {
-  let changedFiles: string[] = [];
-  let deletedFiles: string[] = [];
-
-  for (const change of changes) {
-    changedFiles = unique(
-      subtract(changedFiles, change.deletedFiles).concat(change.changedFiles || [])
-    );
-    deletedFiles = unique(
-      subtract(deletedFiles, change.changedFiles).concat(change.deletedFiles || [])
-    );
+  const changedFilesSet = new Set<string>();
+  const deletedFilesSet = new Set<string>();
+
+  for (const { changedFiles = [], deletedFiles = [] } of changes) {
+    for (const changedFile of changedFiles) {
+      changedFilesSet.add(changedFile);
+      deletedFilesSet.delete(changedFile);
+    }
+    for (const deletedFile of deletedFiles) {
+      changedFilesSet.delete(deletedFile);
+      deletedFilesSet.add(deletedFile);
+    }
   }
 
   return {
-    changedFiles,
-    deletedFiles,
+    changedFiles: Array.from(changedFilesSet),
+    deletedFiles: Array.from(deletedFilesSet),
   };
 }
 
-export { FilesChange, getFilesChange, updateFilesChange, clearFilesChange, aggregateFilesChanges };
+export {
+  FilesChange,
+  getFilesChange,
+  consumeFilesChange,
+  updateFilesChange,
+  clearFilesChange,
+  aggregateFilesChanges,
+};

src/files-change.ts

@@ -1,6 +1,6 @@
 import chalk from 'chalk';
 
-import type { Formatter } from './Formatter';
+import type { Formatter } from './formatter';
 
 function createBasicFormatter(): Formatter {
   return function basicFormatter(issue) {

src/formatter/BasicFormatter.ts renamed to src/formatter/basic-formatter.ts

@@ -3,8 +3,8 @@ import os from 'os';
 import { codeFrameColumns } from '@babel/code-frame';
 import fs from 'fs-extra';
 
-import { createBasicFormatter } from './BasicFormatter';
-import type { Formatter } from './Formatter';
+import { createBasicFormatter } from './basic-formatter';
+import type { Formatter } from './formatter';
 import { BabelCodeFrameOptions } from './types/babel__code-frame';
 
 function createCodeFrameFormatter(options?: BabelCodeFrameOptions): Formatter {

src/formatter/CodeFrameFormatter.ts renamed to src/formatter/code-frame-formatter.ts

@@ -1,13 +1,11 @@
-import { createBasicFormatter } from './BasicFormatter';
-import { createCodeFrameFormatter } from './CodeFrameFormatter';
-import type { Formatter } from './Formatter';
-import type { CodeframeFormatterOptions, FormatterOptions } from './FormatterOptions';
+import { createBasicFormatter } from './basic-formatter';
+import { createCodeFrameFormatter } from './code-frame-formatter';
+import type { Formatter } from './formatter';
+import type { CodeframeFormatterOptions, FormatterOptions } from './formatter-options';
 
-type FormatterConfiguration = Formatter;
+type FormatterConfig = Formatter;
 
-function createFormatterConfiguration(
-  options: FormatterOptions | undefined
-): FormatterConfiguration {
+function createFormatterConfig(options: FormatterOptions | undefined): FormatterConfig {
   if (typeof options === 'function') {
     return options;
   }
@@ -23,16 +21,16 @@ function createFormatterConfiguration(
   }
 
   if (type === 'codeframe') {
-    const configuration =
+    const config =
       options && typeof options === 'object'
         ? (options as CodeframeFormatterOptions).options || {}
         : {};
-    return createCodeFrameFormatter(configuration);
+    return createCodeFrameFormatter(config);
   }
 
   throw new Error(
     `Unknown "${type}" formatter. Available types are: "basic", "codeframe" or a custom function.`
   );
 }
 
-export { FormatterConfiguration, createFormatterConfiguration };
+export { FormatterConfig, createFormatterConfig };

src/formatter/FormatterConfiguration.ts renamed to src/formatter/formatter-config.ts

@@ -1,4 +1,4 @@
-import type { Formatter } from './Formatter';
+import type { Formatter } from './formatter';
 import type { BabelCodeFrameOptions } from './types/babel__code-frame';
 
 type FormatterType = 'basic' | 'codeframe';

src/formatter/FormatterOptions.ts renamed to src/formatter/formatter-options.ts

@@ -1,6 +1,6 @@
-export * from './Formatter';
-export * from './BasicFormatter';
-export * from './CodeFrameFormatter';
-export * from './WebpackFormatter';
-export * from './FormatterOptions';
-export * from './FormatterConfiguration';
+export * from './formatter';
+export * from './basic-formatter';
+export * from './code-frame-formatter';
+export * from './webpack-formatter';
+export * from './formatter-options';
+export * from './formatter-config';