eslint

Author: Piotr Oleś

.eslintrc.json

@@ -0,0 +1,24 @@
+{
+    "env": {
+        "node": true
+    },
+    "extends": "eslint:recommended",
+    "rules": {
+        "indent": [
+            "error",
+            2
+        ],
+        "linebreak-style": [
+            "error",
+            "unix"
+        ],
+        "quotes": [
+            "error",
+            "single"
+        ],
+        "semi": [
+            "error",
+            "always"
+        ]
+    }
+}

LICENSE

@@ -1,6 +1,6 @@
 MIT License
 
-Copyright (c) 2017 Piotr Oleś
+Copyright (c) 2017 Realytics
 
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal

karma.conf.js

@@ -1,7 +1,3 @@
-var webpack = require('webpack');
-var path = require('path');
-var process = require('process');
-
 module.exports = function (config) {
   config.set({
     browsers: ['PhantomJS'],

lib/CancellationToken.js

@@ -4,28 +4,28 @@ var os = require('os');
 var path = require('path');
 var crypto = require('crypto');
 
-function CancellationToken(cancellationFileName, isCancelled) {
+function CancellationToken (cancellationFileName, isCancelled) {
   this.isCancelled = !!isCancelled;
   this.cancellationFileName = cancellationFileName || crypto.randomBytes(64).toString('hex');
   this.lastCancellationCheckTime = 0;
 }
 module.exports = CancellationToken;
 
-CancellationToken.createFromJSON = function(json) {
+CancellationToken.createFromJSON = function (json) {
   return new CancellationToken(
     json.cancellationFileName,
     json.isCancelled
   );
 };
 
-CancellationToken.prototype.toJSON = function() {
+CancellationToken.prototype.toJSON = function () {
   return {
     cancellationFileName: this.cancellationFileName,
     isCancelled: this.isCancelled
   };
 };
 
-CancellationToken.prototype.isCancellationRequested = function() {
+CancellationToken.prototype.isCancellationRequested = function () {
   if (this.isCancelled) {
     return true;
   }
@@ -42,13 +42,13 @@ CancellationToken.prototype.isCancellationRequested = function() {
   return this.isCancelled;
 };
 
-CancellationToken.prototype.throwIfCancellationRequested = function() {
+CancellationToken.prototype.throwIfCancellationRequested = function () {
   if (this.isCancellationRequested()) {
     throw new ts.OperationCanceledException();
   }
 };
 
-CancellationToken.prototype.requestCancellation = function() {
+CancellationToken.prototype.requestCancellation = function () {
   fs.writeFileSync(getCancellationFilePath(this.cancellationFileName), '');
 };
 
@@ -58,6 +58,6 @@ CancellationToken.prototype.cleanupCancellation = function () {
   }
 };
 
-function getCancellationFilePath(cancellationFileName) {
+function getCancellationFilePath (cancellationFileName) {
   return path.join(os.tmpdir(), cancellationFileName);
 }

lib/FilesRegister.js

@@ -1,5 +1,5 @@
 
-function FilesRegister(oldRegister) {
+function FilesRegister (oldRegister) {
   this.register = {};
 
   if (oldRegister) {

lib/FilesWatcher.js

@@ -2,7 +2,7 @@ var chokidar = require('chokidar');
 var path = require('path');
 var startsWith = require('lodash.startswith');
 
-function FilesWatcher(watchPaths, watchExtensions) {
+function FilesWatcher (watchPaths, watchExtensions) {
   this.watchPaths = watchPaths;
   this.watchExtensions = watchExtensions;
   this.watchers = [];
@@ -11,8 +11,8 @@ function FilesWatcher(watchPaths, watchExtensions) {
 }
 module.exports = FilesWatcher;
 
-FilesWatcher.prototype.isFileSupported = function(filePath) {
-  return -1 !== this.watchExtensions.indexOf(path.extname(filePath));
+FilesWatcher.prototype.isFileSupported = function (filePath) {
+  return this.watchExtensions.indexOf(path.extname(filePath)) !== -1;
 };
 
 FilesWatcher.prototype.watch = function () {
@@ -21,14 +21,14 @@ FilesWatcher.prototype.watch = function () {
       watchPath,
       { persistent: true }
     )
-    .on('change', function(filePath, stats) {
+    .on('change', function (filePath, stats) {
       if (this.isFileSupported(filePath)) {
         this.changeListeners.forEach(function (changeListener) {
           changeListener(filePath, stats);
         });
       }
     }.bind(this))
-    .on('unlink', function(filePath) {
+    .on('unlink', function (filePath) {
       if (this.isFileSupported(filePath)) {
         this.unlinkListeners.forEach(function (unlinkListener) {
           unlinkListener(filePath);
@@ -54,19 +54,19 @@ FilesWatcher.prototype.isWatching = function () {
 FilesWatcher.prototype.onChange = function (changeListener) {
   this.changeListeners.push(changeListener);
 
-  return function unsubscribe() {
+  return function unsubscribe () {
     this.changeListeners.filter(function (listener) {
       return listener !== changeListener;
-    })
+    });
   }.bind(this);
 };
 
 FilesWatcher.prototype.onUnlink = function (unlinkListener) {
   this.unlinkListeners.push(unlinkListener);
 
-  return function unsubscribe() {
+  return function unsubscribe () {
     this.unlinkListeners.filter(function (listener) {
       return listener !== unlinkListener;
-    })
+    });
   }.bind(this);
 };

lib/IncrementalChecker.js

@@ -1,10 +1,11 @@
 var ts = require('typescript');
 var fs = require('fs');
 var path = require('path');
+var endsWith = require('lodash.endswith');
 var FilesRegister = require('./FilesRegister');
 var FilesWatcher = require('./FilesWatcher');
 
-function IncrementalChecker(programConfigFile, linterConfigFile, watchPaths) {
+function IncrementalChecker (programConfigFile, linterConfigFile, watchPaths) {
   this.programConfigFile = programConfigFile;
   this.linterConfigFile = linterConfigFile;
   this.watchPaths = watchPaths;
@@ -25,11 +26,11 @@ IncrementalChecker.loadLinterConfig = function (configFile) {
   return tslint.Configuration.loadConfigurationFromPath(configFile);
 };
 
-IncrementalChecker.createProgram = function(programConfig, register, watcher, oldProgram) {
+IncrementalChecker.createProgram = function (programConfig, register, watcher, oldProgram) {
   var host = ts.createCompilerHost(programConfig.options);
   var originGetSourceFile = host.getSourceFile;
 
-  host.getSourceFile = function(filePath, languageVersion, onError) {
+  host.getSourceFile = function (filePath, languageVersion, onError) {
     // first check if watcher is watching file - if not - check it's mtime
     if (!watcher.isWatchingFile(filePath)) {
       var stats = fs.statSync(filePath);
@@ -56,13 +57,13 @@ IncrementalChecker.createProgram = function(programConfig, register, watcher, ol
   );
 };
 
-IncrementalChecker.createLinter = function(program) {
+IncrementalChecker.createLinter = function (program) {
   var tslint = require('tslint');
 
   return new tslint.Linter({ fix: false }, program);
 };
 
-IncrementalChecker.prototype.nextIteration = function() {
+IncrementalChecker.prototype.nextIteration = function () {
   this.register = new FilesRegister(this.register);
 
   if (!this.watcher) {
@@ -87,7 +88,7 @@ IncrementalChecker.prototype.nextIteration = function() {
   this.linter = IncrementalChecker.createLinter(this.program);
 };
 
-IncrementalChecker.prototype.getDiagnostics = function(cancellationToken) {
+IncrementalChecker.prototype.getDiagnostics = function (cancellationToken) {
   var diagnostics = this.program.getSemanticDiagnostics(undefined, cancellationToken);
 
   return diagnostics.map(function (diagnostic) {
@@ -106,11 +107,11 @@ IncrementalChecker.prototype.getDiagnostics = function(cancellationToken) {
   });
 };
 
-IncrementalChecker.prototype.getLints = function(cancellationToken) {
+IncrementalChecker.prototype.getLints = function (cancellationToken) {
   this.register.forEach(function (fileName, fileEntry) {
     cancellationToken.throwIfCancellationRequested();
 
-    if (!fileName.endsWith('.d.ts') && !fileEntry.linted) {
+    if (!endsWith(fileName, '.d.ts') && !fileEntry.linted) {
       this.linter.lint(fileName, undefined, this.linterConfig);
       fileEntry.linted = true;
     }
@@ -134,6 +135,6 @@ IncrementalChecker.prototype.getLints = function(cancellationToken) {
       file: lint.getFileName(),
       line: position.line,
       character: position.character
-    }
+    };
   });
 };