Skip to content

Commit 5fbc15a

Browse files
authored
fix: measurement formatting as per SI rules (#402)
According to the SI, there should be a space between a measurement quantity and its unit symbol, so this commit fixes this issue.
1 parent 5be63fa commit 5fbc15a

File tree

4 files changed

+4
-4
lines changed

4 files changed

+4
-4
lines changed

src/CancellationToken.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ export class CancellationToken {
5757
const duration = Math.abs(time - this.lastCancellationCheckTime);
5858

5959
if (duration > 10) {
60-
// check no more than once every 10ms
60+
// check no more than once every 10 ms
6161
this.lastCancellationCheckTime = time;
6262
this.isCancelled = fileExistsSync(this.getCancellationFilePath());
6363
}

src/CompilerHost.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -242,7 +242,7 @@ export class CompilerHost
242242
// We are intercepting all change notifications, and letting
243243
// them through only when webpack starts processing changes.
244244
// Therefore, at this point normally files are already all saved,
245-
// so we do not need to waste another 250ms (hardcoded in TypeScript).
245+
// so we do not need to waste another 250 ms (hardcoded in TypeScript).
246246
// On the other hand there may be occasional glitch, when our incremental
247247
// compiler will receive the notification too late, and process it when
248248
// next compilation would start.

src/index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -716,7 +716,7 @@ class ForkTsCheckerWebpackPlugin {
716716
: '')
717717
);
718718
this.logger.info(
719-
'Time: ' + chalk.bold(Math.round(elapsed / 1e6).toString()) + 'ms'
719+
`Time: ${chalk.bold(Math.round(elapsed / 1e6).toString())} ms`
720720
);
721721
}
722722
};

test/unit/CancellationToken.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,7 @@ describe('[UNIT] CancellationToken', () => {
123123
}).not.toThrowError();
124124
});
125125

126-
it('should throttle check for 10ms', done => {
126+
it('should throttle check for 10 ms', done => {
127127
const tokenA = new CancellationToken(require('typescript'));
128128
const tokenB = CancellationToken.createFromJSON(
129129
// eslint-disable-next-line @typescript-eslint/no-var-requires

0 commit comments

Comments
 (0)