fix: handle undefined paths in getModifiedTime #865
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When building projects in `tsc` build mode (with `typescript.build` set to `true`), some paths passed to `getModifiedTime` will be `undefined`. Previously, this would cause an error and prevent type-checking (see TypeStrong#855). With these changes, the modified time will just be returned as `undefined` in such cases, which allows type checking to complete successfully.
|
+1 - can we get a maintainer to look at this PR? I also just ran into this issue when trying to upgrade typescript. Work around seems reasonable to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #855
When building projects in
tscbuild mode (withtypescript.buildset totrue), some paths passed togetModifiedTimewill beundefined. Previously, this would cause an error and prevent type-checking (see #855). With these changes, the modified time will just be returned asundefinedin such cases, which allows type checking to complete successfully.