chore: TypeScript 5.9 upgrade (#1676)

* feat: upgrade typescript

* fix: add skipLibCheck to deal with webpack / typescript incompatibilities

* chore: stub new tests

* fix: add skipLibCheck to deal with webpack / typescript incompatibilities

* fix: upgrade test output

* chore: yarn lock

* chore: upgrade to [email protected]

* chore: regenerate output after webpack upgrade

* chore: remove 4.x TypeScript tests and add 5.9.2 to matrix

* chore: upgrade version

Author: johnnyreilly

.github/workflows/push.yml

@@ -49,7 +49,7 @@ jobs:
     strategy:
       matrix:
         node: [20, 22]
-        ts: [4.4.2, 4.5.2, 4.6.2, 4.7.3, 4.8.2, 4.9.3, 5.0.4, 5.1.3, 5.2.2, 5.3.3, 5.4.2, 5.5.3, 5.6.2, 5.7.2, 5.8.2, next]
+        ts: [5.0.4, 5.1.3, 5.2.2, 5.3.3, 5.4.2, 5.5.3, 5.6.2, 5.7.2, 5.8.2, 5.9.2, next]
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v3
@@ -76,7 +76,7 @@ jobs:
     strategy:
       matrix:
         node: [20, 22]
-        ts: [4.4.2, 4.5.2, 4.6.2, 4.7.3, 4.8.2, 4.9.3, 5.0.4, 5.1.3, 5.2.2, 5.3.3, 5.4.2, 5.5.3, 5.6.2, 5.7.2, 5.8.2, next]
+        ts: [5.0.4, 5.1.3, 5.2.2, 5.3.3, 5.4.2, 5.5.3, 5.6.2, 5.7.2, 5.8.2, 5.9.2, next]
     runs-on: windows-latest
     steps:
       - uses: actions/checkout@v3

CHANGELOG.md

@@ -1,5 +1,8 @@
 # Changelog
 
+## 9.5.3
+* [chore: typescript 5.9 upgrade](https://github.com/TypeStrong/ts-loader/pull/1676) - thanks @johnnyreilly
+
 ## 9.5.2
 * [fix: add more detailed error messages](https://github.com/TypeStrong/ts-loader/pull/1665) - thanks @hai-x
 

package.json

@@ -1,6 +1,6 @@
 {
   "name": "ts-loader",
-  "version": "9.5.2",
+  "version": "9.5.3",
   "description": "TypeScript loader for webpack",
   "main": "index.js",
   "types": "dist",
@@ -94,7 +94,7 @@
     "mocha": "^6.0.0",
     "prettier": "^2.0.5",
     "rimraf": "^2.6.2",
-    "typescript": "^5.8.2",
+    "typescript": "^5.9.2",
     "webpack": "^5.74.0",
     "webpack-cli": "^4.10.0"
   },

src/after-compile.ts

@@ -462,7 +462,7 @@ function removeCompilationTSLoaderErrors(
   loaderOptions: LoaderOptions
 ) {
   compilation.errors = compilation.errors.filter(
-    error => error.details !== tsLoaderSource(loaderOptions)
+    error => error instanceof webpack.WebpackError && error.details !== tsLoaderSource(loaderOptions)
   );
 }
 

src/index.ts

@@ -298,6 +298,7 @@ function makeLoaderOptions(
   const hasForkTsCheckerWebpackPlugin =
     loaderContext._compiler?.options.plugins.some(
       plugin =>
+        plugin !== null &&
         typeof plugin === 'object' &&
         plugin.constructor?.name === 'ForkTsCheckerWebpackPlugin'
     );
@@ -477,7 +478,7 @@ function getEmit(
 
   addDependenciesFromSolutionBuilder(instance, filePath, addDependency);
 
-  loaderContext._module!.buildMeta.tsLoaderDefinitionFileVersions =
+  if (loaderContext._module && loaderContext._module.buildMeta) loaderContext._module.buildMeta.tsLoaderDefinitionFileVersions =
     dependencies.map(
       defFilePath =>
         path.relative(loaderContext.rootContext, defFilePath) +

src/instances.ts

@@ -141,7 +141,7 @@ function successfulTypeScriptInstance(
       error: makeError(
         loaderOptions,
         colors.red('error while reading tsconfig.json:' + EOL + message),
-        file
+        file ?? ''
       ),
     };
   }

src/watch-run.ts

@@ -102,10 +102,14 @@ function updateFile(
       loader.loadModule(request, (err, source) => {
         if (err) {
           reject(err);
-        } else {
+        } else if (typeof source === 'string') {
           const text = JSON.parse(source);
           updateFileWithText(instance, key, filePath, () => text);
           resolve();
+        } else if (Buffer.isBuffer(source)) {
+          const text = JSON.parse(source.toString('utf8'));
+          updateFileWithText(instance, key, filePath, () => text);
+          resolve();
         }
       });
     } else {