Maintenance (#1956)

* Get rid of tons of unnecessary destructuring in tests

* control in-process concurrency w/env var
formatting in testlib
split `context` into `context` and `contextEach`; stop sprinkling `once` around
`beforeAll` -> `before`
`runIf` -> `if`
`runSerially` -> `serial`, makes `serial` overloaded

* extract testlib to git dep

* extract getStream/expectStream to git dep

* Replace bundled fs-fixture-builder with git dep

* fix lockfile

* try to make yarn happy grrr

* test against node 20 nightly, since 19 seems not to be building every night

* bump git deps

* lockfile

* try to fix install on node nightly

* organize test helpers into multiple files, remove @yarnpkg/fslib dep, extract ctxTmpDir to its own context builder

* fix bug in tests supposed to run *outside* of the git clone directory

* fix transitive dep crash

* fix fs-fixture-builder bug

Author: cspotcode

.github/workflows/continuous-integration.yml

@@ -89,8 +89,8 @@ jobs:
             typescriptFlag: next
           # Node nightly
           - flavor: 5
-            node: 19-nightly
-            nodeFlag: 19_nightly
+            node: 20-nightly
+            nodeFlag: 20_nightly
             typescript: latest
             typescriptFlag: latest
     steps:

.gitignore

@@ -13,6 +13,7 @@ npm-debug.log
 /website/static/api
 /tsconfig.tsbuildinfo
 /temp
+/tmp
 /yarn-error.log
 /.yarn/install-state.gz
 /tests/.yarn/install-state.gz

ava.config.cjs

@@ -12,7 +12,8 @@ module.exports = {
     // This avoids passing it to spawned processes under test, which would negatively affect
     // their behavior.
     FORCE_COLOR: '3',
-    NODE_PATH: ''
+    NODE_PATH: '',
+    CONCURRENT_TESTS: '4'
   },
   require: ['./src/test/remove-env-var-force-color.js'],
   nodeArguments: ['--loader', './src/test/test-loader.mjs', '--no-warnings'],

justfile

@@ -21,6 +21,12 @@ regenerate:
 install:
   yarn
 
+yarn *ARGS:
+  yarn "$@"
+
+node *ARGS:
+  node "$@"
+
 # EVERYTHING BELOW THIS LINE IS AUTO-GENERATED FROM PACKAGE.JSON
 # DO NOT MODIFY BY HAND
 

package.json

@@ -108,6 +108,9 @@
   },
   "homepage": "https://typestrong.org/ts-node",
   "devDependencies": {
+    "@TypeStrong/fs-fixture-builder": "github:TypeStrong/fs-fixture-builder#8abd1494280116ff5318dde2c50ad01e1663790c",
+    "@cspotcode/ava-lib": "github:cspotcode/ava-lib#edcc1885d192d08d5af83490af9341468402ec41",
+    "@cspotcode/expect-stream": "github:cspotcode/node-expect-stream#4e425ff1eef240003af8716291e80fbaf3e3ae8f",
     "@microsoft/api-extractor": "^7.19.4",
     "@swc/core": ">=1.3.32",
     "@swc/wasm": ">=1.3.32",
@@ -119,12 +122,10 @@
     "@types/react": "^16.14.19",
     "@types/rimraf": "^3.0.0",
     "@types/semver": "^7.1.0",
-    "@yarnpkg/fslib": "^2.4.0",
     "ava": "^5.1.1",
     "axios": "^0.21.1",
     "dprint": "^0.25.0",
     "expect": "27.0.2",
-    "get-stream": "^6.0.0",
     "lodash": "^4.17.15",
     "nyc": "^15.0.1",
     "outdent": "^0.8.0",
@@ -135,7 +136,7 @@
     "throat": "^6.0.1",
     "typedoc": "^0.22.10",
     "typescript": "4.7.4",
-    "typescript-json-schema": "^0.53.0"
+    "typescript-json-schema": "^0.54.0"
   },
   "peerDependencies": {
     "@swc/core": ">=1.2.50",

scripts/node-nightly.sh

@@ -0,0 +1,27 @@
+#!/usr/bin/env bash
+
+# Hacky script to grab node nightly and plonk it into node_modules/.bin, for
+# locally testing against nightly builds.
+
+set -euo pipefail
+shopt -s inherit_errexit
+__dirname="$(CDPATH= cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
+cd "$__dirname/.."
+
+set -x
+
+mkdir -p tmp
+
+version=$(curl https://nodejs.org/download/nightly/index.json | jq -r '.[0].version')
+[ -e "tmp/$version.tar.xz" ] || \
+  curl -o "tmp/$version.tar.xz" "https://nodejs.org/download/nightly/$version/node-$version-linux-x64.tar.xz"
+
+[ -e "tmp/$version.tar" ] || \
+  unxz "tmp/$version.tar.xz"
+
+{
+  cd tmp
+  tar -xvf "$version.tar"
+}
+
+ln -s "../../tmp/node-$version-linux-x64/bin/node" ./node_modules/.bin/node

src/test/ci-node-and-ts-versions.spec.ts

@@ -8,7 +8,7 @@ import { context, expect } from './testlib';
 
 const test = context(ctxTsNode);
 test.suite('Confirm node and typescript versions on CI', (test) => {
-  test.runIf(!!process.env.CI);
+  test.if(!!process.env.CI);
   test('node version is correct', async (t) => {
     const expectedVersion = process.env.TEST_MATRIX_NODE_VERSION!;
     const actualVersion = process.versions.node;

src/test/diagnostics.spec.ts

@@ -6,24 +6,22 @@ import { once } from 'lodash';
 const test = context(ctxTsNode);
 
 test.suite('TSError diagnostics', ({ context }) => {
-  const test = context(
-    once(async (t) => {
-      // Locking to es2020, because:
-      // 1) es2022 -- default in @tsconfig/bases for node18 -- changes this diagnostic
-      //   to be a composite "No overload matches this call."
-      // 2) TS 4.2 doesn't support es2021 or higher
-      const service = t.context.tsNodeUnderTest.create({
-        compilerOptions: { target: 'es5', lib: ['es2020'] },
-        skipProject: true,
-      });
-      try {
-        service.compile('new Error(123)', 'test.ts');
-      } catch (err) {
-        return { err: err as TSError };
-      }
-      return { err: undefined };
-    })
-  );
+  const test = context(async (t) => {
+    // Locking to es2020, because:
+    // 1) es2022 -- default in @tsconfig/bases for node18 -- changes this diagnostic
+    //   to be a composite "No overload matches this call."
+    // 2) TS 4.2 doesn't support es2021 or higher
+    const service = t.context.tsNodeUnderTest.create({
+      compilerOptions: { target: 'es5', lib: ['es2020'] },
+      skipProject: true,
+    });
+    try {
+      service.compile('new Error(123)', 'test.ts');
+    } catch (err) {
+      return { err: err as TSError };
+    }
+    return { err: undefined };
+  });
 
   const diagnosticCode = 2345;
   const diagnosticMessage =