Fix indefinite wait and simplify per De Morgan's law #2156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These would otherwise result in syntax like `… node:sea = …`, which causes further problems with indefinite wait. Fixes: TypeStrong#2150
De Morgan's rule: `(not a) and (not b) = not (a or b)`
Hi-Angel
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First commit fixes the bug as described. Second commit simplifies comparison chain by using De Morgan's law.
Note: as described on the referred issue, there's an exception being printed with the commit, however the commit is unrelated to the exception, it's a problem elsewhere (maybe even fixed in other PRs, I've seen there something related to "newer TypeScript support"), because if TS deps are downgraded, exception disappears.
Fixes: #2150