Move logging for bad URLs to router

Also fix an issue which was resulting in `#undefined` links

Author: Gerrit0

src/lib/output/router.ts

@@ -180,6 +180,11 @@ export abstract class BaseRouter implements Router {
     }
 
     getAnchor(refl: Reflection): string | undefined {
+        if (!this.anchors.has(refl)) {
+            this.application.logger.verbose(
+                `${refl.getFullName()} does not have an anchor but one was requested, this is a bug in the theme`,
+            );
+        }
         return this.anchors.get(refl);
     }
 
@@ -209,6 +214,9 @@ export abstract class BaseRouter implements Router {
         }
 
         if (equal && !to.isProject()) {
+            if (fromUrl === toUrl) {
+                return "";
+            }
             return `#${this.getAnchor(to)}`;
         }
 

src/lib/output/themes/MarkedPlugin.tsx

@@ -153,7 +153,7 @@ export class MarkedPlugin extends ContextAwareRendererComponent {
                                     // If we don't have a URL the user probably linked to some deeply nested property
                                     // which doesn't get an assigned URL. We'll walk upwards until we find a reflection
                                     // which has a URL and link to that instead.
-                                    if (!url) {
+                                    if (typeof url === "undefined") {
                                         // Walk upwards to find something we can link to.
                                         let target = part.target.parent!;
                                         while (!context.router.hasUrl(target)) {

src/lib/output/themes/default/DefaultThemeRenderContext.ts

@@ -37,7 +37,7 @@ import { reflectionTemplate } from "./templates/reflection.js";
 import { typeDeclaration, typeDetails, typeDetailsIfUseful } from "./partials/typeDetails.js";
 import { moduleMemberSummary, moduleReflection } from "./partials/moduleReflection.js";
 import type { Router } from "../../router.js";
-import type { NeverIfInternal, TranslatedString } from "#utils";
+import type { NeverIfInternal } from "#utils";
 
 function bind<F, L extends any[], R>(fn: (f: F, ...a: L) => R, first: F) {
     return (...r: L) => fn(first, ...r);
@@ -88,25 +88,11 @@ export class DefaultThemeRenderContext {
     };
 
     getAnchor = (reflection: Reflection): string | undefined => {
-        const anchor = this.router.getAnchor(reflection);
-        if (!anchor) {
-            // This will go to debug level before release
-            this.theme.application.logger.warn(
-                `${reflection.getFullName()} does not have an anchor but one was requested when generating page for ${this.model.getFullName()}, this is a bug` as TranslatedString,
-            );
-        }
-        return anchor;
+        return this.router.getAnchor(reflection);
     };
 
     urlTo = (reflection: Reflection): string | undefined => {
-        if (this.router.hasUrl(reflection)) {
-            return this.router.relativeUrl(this.page.model, reflection);
-        }
-        // This will go to debug level before release
-        this.theme.application.logger.warn(
-            `${reflection.getFullName()} does not have a URL but was linked to when generating page for ${this.model.getFullName()}, this is a bug` as TranslatedString,
-        );
-        return undefined;
+        return this.router.relativeUrl(this.page.model, reflection);
     };
 
     markdown = (

src/test/output/router.test.ts

@@ -131,6 +131,7 @@ describe("KindRouter", () => {
         equal(router.relativeUrl(Obj, ObjArray), "ObjArray.html");
         equal(router.relativeUrl(Foo, codeGen), "#codegeneration");
         equal(router.relativeUrl(iterator, codeGen), "#codegeneration");
+        equal(router.relativeUrl(Foo, Foo), "");
     });
 
     it("Can get a URL to an asset relative to the base", () => {