Fix excludeNotDocumented on arrow functions

Resolves #2156

Author: Gerrit0

CHANGELOG.md

@@ -15,6 +15,7 @@
 ### Bug Fixes
 
 -   Entry points under `node_modules` will no longer be ignored, #2151.
+-   Corrected behavior of `excludeNotDocumented` on arrow function-variables, #2156.
 -   Added `package.json` to exports declaration.
 
 ### Thanks!

src/lib/converter/plugins/CommentPlugin.ts

@@ -464,6 +464,18 @@ export class CommentPlugin extends ConverterComponent {
         }
 
         if (!comment) {
+            // We haven't moved comments from the parent for signatures without a direct
+            // comment, so don't exclude those due to not being documented.
+            if (
+                reflection.kindOf(
+                    ReflectionKind.CallSignature |
+                        ReflectionKind.ConstructorSignature
+                ) &&
+                reflection.parent?.comment
+            ) {
+                return false;
+            }
+
             if (this.excludeNotDocumented) {
                 // Don't let excludeNotDocumented remove parameters.
                 if (

src/test/converter2/issues/gh2156.ts

@@ -0,0 +1,6 @@
+/**
+ * Is documented
+ */
+export const foo = (foo: string): boolean => {
+    return true;
+};

src/test/issueTests.ts

@@ -29,8 +29,8 @@ function query(project: ProjectReflection, name: string) {
 }
 
 export const issueTests: {
-    [issue: `pre${string}`]: (app: Application) => void;
-    [issue: `gh${string}`]: (
+    [issue: `pre${bigint}${string}`]: (app: Application) => void;
+    [issue: `gh${bigint}${string}`]: (
         project: ProjectReflection,
         logger: TestLogger
     ) => void;
@@ -836,4 +836,16 @@ export const issueTests: {
             "One"
         );
     },
+
+    pre2156(app) {
+        app.options.setValue("excludeNotDocumented", true);
+    },
+    gh2156(project) {
+        const foo = query(project, "foo");
+        equal(foo.signatures?.length, 1);
+        equal(
+            Comment.combineDisplayParts(foo.signatures[0].comment?.summary),
+            "Is documented"
+        );
+    },
 };