Fix #2842

Author: Gerrit0

CHANGELOG.md

@@ -14,6 +14,7 @@ title: Changelog
 
 -   Fixed an issue where TypeDoc would incorrectly ignore type arguments in references, #2823.
 -   Improved narrator support for labeling icons, #2832.
+-   Fixed an issue with `@class` incorrectly handling mapped types, #2842.
 
 ### Thanks!
 

scripts/testcase.js

@@ -46,7 +46,7 @@ async function main() {
     const data = JSON.parse(await exec(curl.replace("ISSUE", issue)));
 
     const parser = md();
-    const tokens = parser.parse(data.body, {});
+    const tokens = parser.parse(data.body || "", {});
 
     const code =
         tokens.find(

src/lib/converter/symbols.ts

@@ -720,8 +720,13 @@ function convertProperty(
     }
 
     // Special case: We pretend properties are methods if they look like methods.
-    // This happens with mixins / weird inheritance.
+    // This happens with mixins / weird inheritance. Don't do this if the type
+    // doesn't have call signatures to avoid converting non-functions. This can
+    // happen if @class is used and functions are converted to their return type
+    // with a mapped type (e.g. with Vue's `computed` properties)
+    const type = context.checker.getTypeOfSymbol(symbol);
     if (
+        type.getCallSignatures().length &&
         declarations.length &&
         declarations.every(
             (decl) =>

src/test/converter2/issues/gh2842.ts

@@ -0,0 +1,19 @@
+declare function defineComponent<
+    T extends Record<string, () => any>,
+    U extends Record<string, any>,
+>(component: {
+    computed: T;
+    props: U;
+}): new () => U & { [K in keyof T]: ReturnType<T[K]> };
+
+/** @class */
+export const ComputedClass = defineComponent({
+    computed: {
+        hello() {
+            return "hello";
+        },
+    },
+    props: {
+        name: "world",
+    },
+});

src/test/issues.c2.test.ts

@@ -2014,4 +2014,12 @@ describe("Issue Tests", () => {
         equal(returnTypes, expectedTypes);
         equal(paramTypes, expectedTypes);
     });
+
+    it("#2842 handles computed properties with @class", () => {
+        const project = convert();
+        const hello = query(project, "ComputedClass.hello");
+
+        equal(hello.kind, ReflectionKind.Property);
+        equal(hello.type?.toString(), "string");
+    });
 });