Merge branch 'fix/dx-silent-test-passes'

Author: Chemaclass

tests/unit/assert_basic_test.sh

@@ -4,7 +4,7 @@
 # shellcheck disable=SC2329
 
 function test_successful_fail() {
-  true || bashunit::fail "This cannot fail"
+  assert_empty "$(true || bashunit::fail "This cannot fail")"
 }
 
 function test_unsuccessful_fail() {

tests/unit/env_test.sh

@@ -55,6 +55,7 @@ function test_env_flag_returns_failure_when_false() {
   fi
 
   eval "export $var_name='$original_value'"
+  assert_successful_code 0
 }
 
 function provide_boolean_flags_false() {
@@ -90,6 +91,7 @@ function test_is_dev_mode_disabled_when_dev_log_empty() {
   fi
 
   export BASHUNIT_DEV_LOG="$original"
+  assert_successful_code 0
 }
 
 function test_is_tap_output_enabled_when_format_is_tap() {
@@ -113,6 +115,7 @@ function test_is_tap_output_disabled_when_format_is_not_tap() {
   fi
 
   export BASHUNIT_OUTPUT_FORMAT="$original"
+  assert_successful_code 0
 }
 
 function test_active_internet_connection_returns_failure_when_no_network() {
@@ -126,6 +129,7 @@ function test_active_internet_connection_returns_failure_when_no_network() {
   fi
 
   export BASHUNIT_NO_NETWORK="$original"
+  assert_successful_code 0
 }
 
 function test_find_terminal_width_returns_a_number() {

…xtures/find_total_tests/provider_test.sh …res/find_total_tests/provider_fixture.shtests/unit/fixtures/find_total_tests/provider_test.sh renamed to tests/unit/fixtures/find_total_tests/provider_fixture.sh tests/unit/fixtures/find_total_tests/provider_test.sh renamed to tests/unit/fixtures/find_total_tests/provider_fixture.sh

@@ -292,39 +292,39 @@ function test_find_total_tests_no_files() {
 
 function test_find_total_tests_simple_file() {
   local file
-  file="$(bashunit::current_dir)/fixtures/find_total_tests/simple_test.sh"
+  file="$(bashunit::current_dir)/fixtures/find_total_tests/simple_fixture.sh"
 
   assert_same "2" "$(helpers_test::find_total_in_subshell "" "$file")"
 }
 
 function test_find_total_tests_simple_file_bash() {
   local file
-  file="$(bashunit::current_dir)/fixtures/find_total_tests/simple_test.bash"
+  file="$(bashunit::current_dir)/fixtures/find_total_tests/simple_fixture.bash"
 
   assert_same "2" "$(helpers_test::find_total_in_subshell "" "$file")"
 }
 
 function test_find_total_tests_with_provider() {
   local file
-  file="$(bashunit::current_dir)/fixtures/find_total_tests/provider_test.sh"
+  file="$(bashunit::current_dir)/fixtures/find_total_tests/provider_fixture.sh"
 
   assert_same "3" "$(helpers_test::find_total_in_subshell "" "$file")"
 }
 
 function test_find_total_tests_multiple_files() {
   local file1
   local file2
-  file1="$(bashunit::current_dir)/fixtures/find_total_tests/simple_test.sh"
-  file2="$(bashunit::current_dir)/fixtures/find_total_tests/provider_test.sh"
+  file1="$(bashunit::current_dir)/fixtures/find_total_tests/simple_fixture.sh"
+  file2="$(bashunit::current_dir)/fixtures/find_total_tests/provider_fixture.sh"
 
   assert_same "5" "$(helpers_test::find_total_in_subshell "" "$file1" "$file2")"
 }
 
 function test_find_total_tests_with_filter() {
   local file1
   local file2
-  file1="$(bashunit::current_dir)/fixtures/find_total_tests/simple_test.sh"
-  file2="$(bashunit::current_dir)/fixtures/find_total_tests/provider_test.sh"
+  file1="$(bashunit::current_dir)/fixtures/find_total_tests/simple_fixture.sh"
+  file2="$(bashunit::current_dir)/fixtures/find_total_tests/provider_fixture.sh"
 
   assert_same "3" "$(helpers_test::find_total_in_subshell "with_provider" "$file1" "$file2")"
 }
@@ -387,28 +387,28 @@ function test_parse_file_path_filter_with_colon_in_path() {
 
 function test_find_function_at_line_first_function() {
   local file
-  file="$(bashunit::current_dir)/fixtures/find_total_tests/simple_test.sh"
+  file="$(bashunit::current_dir)/fixtures/find_total_tests/simple_fixture.sh"
 
   assert_same "test_first" "$(bashunit::helper::find_function_at_line "$file" 4)"
 }
 
 function test_find_function_at_line_second_function() {
   local file
-  file="$(bashunit::current_dir)/fixtures/find_total_tests/simple_test.sh"
+  file="$(bashunit::current_dir)/fixtures/find_total_tests/simple_fixture.sh"
 
   assert_same "test_second" "$(bashunit::helper::find_function_at_line "$file" 8)"
 }
 
 function test_find_function_at_line_exact_function_line() {
   local file
-  file="$(bashunit::current_dir)/fixtures/find_total_tests/simple_test.sh"
+  file="$(bashunit::current_dir)/fixtures/find_total_tests/simple_fixture.sh"
 
   assert_same "test_first" "$(bashunit::helper::find_function_at_line "$file" 3)"
 }
 
 function test_find_function_at_line_before_any_function() {
   local file
-  file="$(bashunit::current_dir)/fixtures/find_total_tests/simple_test.sh"
+  file="$(bashunit::current_dir)/fixtures/find_total_tests/simple_fixture.sh"
 
   assert_same "" "$(bashunit::helper::find_function_at_line "$file" 1)"
 }