Skip to content

Commit 641153d

Browse files
committed
refactor(nodejstypes): make it obvious that we are excluding node js types when analyzing type properties
1 parent 2f025b7 commit 641153d

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

src/transformer/descriptor/mock/mockProperties.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import { Scope } from '../../scope/scope';
33
import { core } from '../../core/core';
44
import { GetDescriptor } from '../descriptor';
55
import { IsTypescriptType } from '../tsLibs/typecriptLibs';
6-
import { IsNodeType } from '../nodeTypes/nodeTypes';
6+
import { IsNodeJsType } from '../nodeJsTypes/nodeJsTypes';
77
import { GetMockCall } from './mockCall';
88
import {
99
GetMockPropertiesAssignments,
@@ -52,7 +52,7 @@ export function GetMockPropertiesFromDeclarations(
5252
return false;
5353
}
5454

55-
if (IsNodeType(member)) {
55+
if (IsNodeJsType(member)) {
5656
// Workaround to remove any properties coming from @types/node globals
5757
return false;
5858
}

src/transformer/descriptor/nodeTypes/nodeTypes.ts renamed to src/transformer/descriptor/nodeJsTypes/nodeJsTypes.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
11
import type * as ts from 'typescript';
22

3-
const NodeTypesGlobalFile: string = 'node_modules/@types/node/globals.d.ts';
3+
const NodeJsTypesGlobalFile: string = 'node_modules/@types/node/globals.d.ts';
44

5-
export function IsNodeType(node: ts.Node): boolean {
5+
export function IsNodeJsType(node: ts.Node): boolean {
66
const nodeFile: ts.SourceFile = node.getSourceFile();
77

88
if (nodeFile) {
99
const fileName: string = nodeFile.fileName;
10-
return fileName.includes(NodeTypesGlobalFile);
10+
return fileName.includes(NodeJsTypesGlobalFile);
1111
}
1212

1313
return false;

0 commit comments

Comments
 (0)