Stricter code

Author: sdebacker

src/Composers/SidebarViewComposer.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace TypiCMS\Modules\Things\Composers;
 
 use Illuminate\Support\Facades\Gate;
@@ -14,15 +16,22 @@ public function compose(View $view): void
         if (Gate::denies('read things')) {
             return;
         }
-        $view->offsetGet('sidebar')->group(__(config('typicms.modules.things.sidebar.group', 'Content')), function (SidebarGroup $group): void {
-            $group->id = 'content';
-            $group->weight = 30;
-            $group->addItem(__(config('typicms.modules.things.sidebar.label', 'Things')), function (SidebarItem $item): void {
-                $item->id = 'things';
-                $item->icon = config('typicms.modules.things.sidebar.icon');
-                $item->weight = config('typicms.modules.things.sidebar.weight');
-                $item->route('admin::index-things');
-            });
-        });
+
+        $view->offsetGet('sidebar')->group(
+            __(config('typicms.modules.things.sidebar.group', 'Content')),
+            function (SidebarGroup $group): void {
+                $group->id = 'content';
+                $group->weight = 30;
+                $group->addItem(
+                    __(config('typicms.modules.things.sidebar.label', 'Things')),
+                    function (SidebarItem $item): void {
+                        $item->id = 'things';
+                        $item->icon = config('typicms.modules.things.sidebar.icon');
+                        $item->weight = config('typicms.modules.things.sidebar.weight');
+                        $item->route('admin::index-things');
+                    },
+                );
+            },
+        );
     }
 }

src/Exports/Export.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace TypiCMS\Modules\Things\Exports;
 
 use Illuminate\Database\Eloquent\Collection;

src/Facades/Things.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace TypiCMS\Modules\Things\Facades;
 
 use Illuminate\Support\Facades\Facade;

src/Http/Controllers/AdminController.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace TypiCMS\Modules\Things\Http\Controllers;
 
 use Illuminate\Http\RedirectResponse;
@@ -12,7 +14,7 @@
 use TypiCMS\Modules\Things\Http\Requests\FormRequest;
 use TypiCMS\Modules\Things\Models\Thing;
 
-class AdminController extends BaseAdminController
+final class AdminController extends BaseAdminController
 {
     public function index(): View
     {
@@ -30,29 +32,25 @@ public function create(): View
     {
         $model = new Thing();
 
-        return view('things::admin.create')
-            ->with(['model' => $model]);
+        return view('things::admin.create', ['model' => $model]);
     }
 
     public function edit(Thing $thing): View
     {
-        return view('things::admin.edit')
-            ->with(['model' => $thing]);
+        return view('things::admin.edit', ['model' => $thing]);
     }
 
     public function store(FormRequest $request): RedirectResponse
     {
         $thing = Thing::query()->create($request->validated());
 
-        return $this->redirect($request, $thing)
-            ->withMessage(__('Item successfully created.'));
+        return $this->redirect($request, $thing)->withMessage(__('Item successfully created.'));
     }
 
     public function update(Thing $thing, FormRequest $request): RedirectResponse
     {
         $thing->update($request->validated());
 
-        return $this->redirect($request, $thing)
-            ->withMessage(__('Item successfully updated.'));
+        return $this->redirect($request, $thing)->withMessage(__('Item successfully updated.'));
     }
 }

src/Http/Controllers/ApiController.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace TypiCMS\Modules\Things\Http\Controllers;
 
 use Illuminate\Http\JsonResponse;
@@ -11,7 +13,7 @@
 use TypiCMS\Modules\Core\Http\Controllers\BaseApiController;
 use TypiCMS\Modules\Things\Models\Thing;
 
-class ApiController extends BaseApiController
+final class ApiController extends BaseApiController
 {
     /** @return LengthAwarePaginator<int, mixed> */
     public function index(Request $request): LengthAwarePaginator

src/Http/Controllers/PublicController.php

@@ -1,12 +1,14 @@
 <?php
 
+declare(strict_types=1);
+
 namespace TypiCMS\Modules\Things\Http\Controllers;
 
 use Illuminate\View\View;
 use TypiCMS\Modules\Core\Http\Controllers\BasePublicController;
 use TypiCMS\Modules\Things\Models\Thing;
 
-class PublicController extends BasePublicController
+final class PublicController extends BasePublicController
 {
     public function index(): View
     {
@@ -16,8 +18,7 @@ public function index(): View
             ->with('image')
             ->get();
 
-        return view('things::public.index')
-            ->with(['models' => $models]);
+        return view('things::public.index', ['models' => $models]);
     }
 
     public function show(string $slug): View
@@ -27,7 +28,6 @@ public function show(string $slug): View
             ->whereSlugIs($slug)
             ->firstOrFail();
 
-        return view('things::public.show')
-            ->with(['model' => $model]);
+        return view('things::public.show', ['model' => $model]);
     }
 }

src/Http/Requests/FormRequest.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace TypiCMS\Modules\Things\Http\Requests;
 
 use TypiCMS\Modules\Core\Http\Requests\AbstractFormRequest;

src/Models/Thing.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace TypiCMS\Modules\Things\Models;
 
 use Illuminate\Database\Eloquent\Casts\Attribute;
@@ -64,9 +66,7 @@ public function url(?string $locale = null): string
     /** @return Attribute<string, null> */
     protected function thumb(): Attribute
     {
-        return Attribute::make(
-            get: fn () => $this->present()->image(null, 54),
-        );
+        return Attribute::make(get: fn () => $this->present()->image(null, 54));
     }
 
     /** @return BelongsTo<File, $this> */

src/Presenters/ModulePresenter.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace TypiCMS\Modules\Things\Presenters;
 
 use TypiCMS\Modules\Core\Presenters\Presenter;

src/Providers/ModuleServiceProvider.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace TypiCMS\Modules\Things\Providers;
 
 use Illuminate\Foundation\AliasLoader;