Code cleaning

Author: sdebacker

src/Composers/SidebarViewComposer.php

@@ -14,10 +14,10 @@ public function compose(View $view): void
         if (Gate::denies('read things')) {
             return;
         }
-        $view->offsetGet('sidebar')->group(__('Content'), function (SidebarGroup $group) {
+        $view->offsetGet('sidebar')->group(__('Content'), function (SidebarGroup $group): void {
             $group->id = 'content';
             $group->weight = 30;
-            $group->addItem(__('Things'), function (SidebarItem $item) {
+            $group->addItem(__('Things'), function (SidebarItem $item): void {
                 $item->id = 'things';
                 $item->icon = config('typicms.modules.things.sidebar.icon');
                 $item->weight = config('typicms.modules.things.sidebar.weight');

src/Http/Controllers/AdminController.php

@@ -31,7 +31,7 @@ public function create(): View
         $model = new Thing();
 
         return view('things::admin.create')
-            ->with(compact('model'));
+            ->with(['model' => $model]);
     }
 
     public function edit(Thing $thing): View

src/Http/Controllers/ApiController.php

@@ -17,15 +17,14 @@ class ApiController extends BaseApiController
     public function index(Request $request): LengthAwarePaginator
     {
         $query = Thing::query()->selectFields();
-        $data = QueryBuilder::for($query)
+
+        return QueryBuilder::for($query)
             ->allowedSorts(['status_translated', 'title_translated'])
             ->allowedFilters([
                 AllowedFilter::custom('title', new FilterOr()),
             ])
             ->allowedIncludes(['image'])
             ->paginate($request->integer('per_page'));
-
-        return $data;
     }
 
     protected function updatePartial(Thing $thing, Request $request): void

src/Http/Controllers/PublicController.php

@@ -17,7 +17,7 @@ public function index(): View
             ->get();
 
         return view('things::public.index')
-            ->with(compact('models'));
+            ->with(['models' => $models]);
     }
 
     public function show(string $slug): View
@@ -28,6 +28,6 @@ public function show(string $slug): View
             ->firstOrFail();
 
         return view('things::public.show')
-            ->with(compact('model'));
+            ->with(['model' => $model]);
     }
 }

src/Providers/ModuleServiceProvider.php

@@ -32,7 +32,7 @@ public function boot(): void
         /*
          * Add the page in the view.
          */
-        View::composer('things::public.*', function ($view) {
+        View::composer('things::public.*', function ($view): void {
             $view->page = getPageLinkedToModule('things');
         });
     }

src/routes/things.php

@@ -1,5 +1,6 @@
 <?php
 
+use TypiCMS\Modules\Core\Models\Page;
 use Illuminate\Routing\Router;
 use Illuminate\Support\Facades\Route;
 use TypiCMS\Modules\Things\Http\Controllers\AdminController;
@@ -9,11 +10,11 @@
 /*
  * Front office routes
  */
-if ($page = getPageLinkedToModule('things')) {
+if (($page = getPageLinkedToModule('things')) instanceof Page) {
     $middleware = $page->private ? ['public', 'auth'] : ['public'];
     foreach (locales() as $lang) {
         if ($page->isPublished($lang) && $path = $page->path($lang)) {
-            Route::middleware($middleware)->prefix($path)->name($lang . '::')->group(function (Router $router) {
+            Route::middleware($middleware)->prefix($path)->name($lang . '::')->group(function (Router $router): void {
                 $router->get('/', [PublicController::class, 'index'])->name('index-things');
                 $router->get('{slug}', [PublicController::class, 'show'])->name('thing');
             });
@@ -24,7 +25,7 @@
 /*
  * Admin routes
  */
-Route::middleware('admin')->prefix('admin')->name('admin::')->group(function (Router $router) {
+Route::middleware('admin')->prefix('admin')->name('admin::')->group(function (Router $router): void {
     $router->get('things', [AdminController::class, 'index'])->name('index-things')->middleware('can:read things');
     $router->get('things/export', [AdminController::class, 'export'])->name('export-things')->middleware('can:read things');
     $router->get('things/create', [AdminController::class, 'create'])->name('create-thing')->middleware('can:create things');
@@ -36,7 +37,7 @@
 /*
  * API routes
  */
-Route::middleware(['api', 'auth:api'])->prefix('api')->group(function (Router $router) {
+Route::middleware(['api', 'auth:api'])->prefix('api')->group(function (Router $router): void {
     $router->get('things', [ApiController::class, 'index'])->middleware('can:read things');
     $router->patch('things/{thing}', [ApiController::class, 'updatePartial'])->middleware('can:update things');
     $router->post('things/{thing}/duplicate', [ApiController::class, 'duplicate'])->middleware('can:create things');