Skip to content

Commit add3ac0

Browse files
authored
Merge pull request #74 from TypingMind/refactor-youtube-transcript
fix(youtube transcript): properly handle errors when the api encounters a fetch error
2 parents b25c02a + 9bfc63f commit add3ac0

File tree

1 file changed

+12
-2
lines changed

1 file changed

+12
-2
lines changed

src/routes/youtubeTranscript/youtubeTranscriptRouter.ts

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,9 @@ export const youtubeTranscriptRouter: Router = (() => {
2626
});
2727

2828
router.get('/get-transcript', async (_req: Request, res: Response) => {
29+
console.log('Head to get-transcript');
2930
const { videoId } = _req.query;
31+
console.log('Head to get-transcript -> ', videoId);
3032

3133
if (!videoId) {
3234
return new ServiceResponse(
@@ -39,17 +41,25 @@ export const youtubeTranscriptRouter: Router = (() => {
3941

4042
try {
4143
const transcript = await YoutubeTranscript.fetchTranscript(videoId as string);
44+
console.log('Transcript response -> ', JSON.stringify(transcript));
4245
const textOnly = transcript.map((entry) => entry.text).join(' ');
4346
const serviceResponse = new ServiceResponse(
4447
ResponseStatus.Success,
4548
'Transcript fetched successfully',
4649
{ textOnly },
4750
StatusCodes.OK
4851
);
49-
handleServiceResponse(serviceResponse, res);
52+
53+
return handleServiceResponse(serviceResponse, res);
5054
} catch (error) {
5155
const errorMessage = `Error fetching transcript $${(error as Error).message}`;
52-
return new ServiceResponse(ResponseStatus.Failed, errorMessage, null, StatusCodes.INTERNAL_SERVER_ERROR);
56+
const serviceResponse = new ServiceResponse(
57+
ResponseStatus.Failed,
58+
errorMessage,
59+
null,
60+
StatusCodes.INTERNAL_SERVER_ERROR
61+
);
62+
return handleServiceResponse(serviceResponse, res);
5363
}
5464
});
5565
return router;

0 commit comments

Comments
 (0)