Simplify salt generation

Author: Tyrrrz

DotnetRuntimeBootstrapper.AppHost.Cli/DotnetRuntimeBootstrapper.AppHost.Cli.csproj

@@ -16,7 +16,7 @@
 
   <ItemGroup>
     <PackageReference Include="CSharpier.MsBuild" Version="1.2.1" PrivateAssets="all" />
-    <PackageReference Include="PolyShim" Version="2.0.0" PrivateAssets="all" />
+    <PackageReference Include="PolyShim" Version="2.2.0" PrivateAssets="all" />
     <PackageReference Include="QuickJson" Version="1.1.0" PrivateAssets="all" />
   </ItemGroup>
 

DotnetRuntimeBootstrapper.AppHost.Core/DotnetRuntimeBootstrapper.AppHost.Core.csproj

@@ -5,7 +5,7 @@
 
   <ItemGroup>
     <PackageReference Include="CSharpier.MsBuild" Version="1.2.1" PrivateAssets="all" />
-    <PackageReference Include="PolyShim" Version="2.0.0" PrivateAssets="all" />
+    <PackageReference Include="PolyShim" Version="2.2.0" PrivateAssets="all" />
     <PackageReference Include="QuickJson" Version="1.1.0" PrivateAssets="all" />
   </ItemGroup>
 

DotnetRuntimeBootstrapper.AppHost.Core/Utils/Extensions/PathExtensions.cs

@@ -1,7 +1,5 @@
 using System;
-using System.Globalization;
 using System.IO;
-using System.Text;
 
 namespace DotnetRuntimeBootstrapper.AppHost.Core.Utils.Extensions;
 
@@ -11,19 +9,9 @@ internal static class PathExtensions
     {
         public static string GenerateTempFilePath(string fileNameBase)
         {
-            static string GenerateSalt()
-            {
-                var buffer = new StringBuilder(8);
-
-                for (var i = 0; i < 8; i++)
-                    buffer.Append(Random.Shared.Next(0, 10).ToString(CultureInfo.InvariantCulture));
-
-                return buffer.ToString();
-            }
-
             var fileNameWithoutExtension = Path.GetFileNameWithoutExtension(fileNameBase);
             var fileExtension = Path.GetExtension(fileNameBase);
-            var salt = GenerateSalt();
+            var salt = Random.Shared.GetHexString(8, true);
 
             return Path.Combine(
                 Path.GetTempPath(),

DotnetRuntimeBootstrapper.AppHost.Gui/DotnetRuntimeBootstrapper.AppHost.Gui.csproj

@@ -17,7 +17,7 @@
 
   <ItemGroup>
     <PackageReference Include="CSharpier.MsBuild" Version="1.2.1" PrivateAssets="all" />
-    <PackageReference Include="PolyShim" Version="2.0.0" PrivateAssets="all" />
+    <PackageReference Include="PolyShim" Version="2.2.0" PrivateAssets="all" />
     <PackageReference Include="QuickJson" Version="1.1.0" PrivateAssets="all" />
   </ItemGroup>
 

DotnetRuntimeBootstrapper/DotnetRuntimeBootstrapper.csproj

@@ -36,7 +36,7 @@
       PrivateAssets="all"
       GeneratePathProperty="true"
     />
-    <PackageReference Include="PolyShim" Version="2.0.0" PrivateAssets="all" />
+    <PackageReference Include="PolyShim" Version="2.2.0" PrivateAssets="all" />
     <PackageReference
       Include="Ressy"
       Version="1.0.3"