refactor: send metadata fn in datachannel subject

Author: TzuHuanTai

src/conductor.cpp

@@ -200,14 +200,7 @@ void Conductor::SendMetadata(std::shared_ptr<DataChannelSubject> datachannel, st
     }
     try {
         MetaMessage metadata(path);
-        auto body = metadata.ToString();
-        int body_size = body.length();
-        auto header = std::to_string(body_size);
-        int header_size = header.length();
-
-        datachannel->Send(CommandType::METADATA, (uint8_t *)header.c_str(), header_size);
-        datachannel->Send(CommandType::METADATA, (uint8_t *)body.c_str(), body_size);
-        datachannel->Send(CommandType::METADATA, nullptr, 0);
+        datachannel->Send(metadata);
     } catch (const std::exception &e) {
         ERROR_PRINT("%s", e.what());
     }

src/data_channel_subject.cpp

@@ -81,8 +81,8 @@ void DataChannelSubject::Send(CommandType type, const uint8_t *data, size_t size
 
     while (bytes_read < size) {
         if (data_channel_->buffered_amount() + CHUNK_SIZE > data_channel_->MaxSendQueueSize()) {
-            sleep(1);
-            DEBUG_PRINT("Sleeping for 1 second due to MaxSendQueueSize reached.");
+            usleep(100);
+            DEBUG_PRINT("Sleeping for 100 microsecond due to MaxSendQueueSize reached.");
             continue;
         }
         int read_size = std::min(CHUNK_SIZE - header_size, size - bytes_read);
@@ -104,6 +104,18 @@ void DataChannelSubject::Send(const uint8_t *data, size_t size) {
     data_channel_->Send(data_buffer);
 }
 
+void DataChannelSubject::Send(MetaMessage metadata) {
+    auto type = CommandType::METADATA;
+    auto body = metadata.ToString();
+    int body_size = body.length();
+    auto header = std::to_string(body_size);
+    int header_size = header.length();
+
+    Send(type, (uint8_t *)header.c_str(), header_size);
+    Send(type, (uint8_t *)body.c_str(), body_size);
+    Send(type, nullptr, 0);
+}
+
 void DataChannelSubject::Send(Buffer image) {
     const int file_size = image.length;
     auto type = CommandType::SNAPSHOT;

src/data_channel_subject.h

@@ -85,7 +85,7 @@ class DataChannelSubject : public webrtc::DataChannelObserver,
     std::shared_ptr<Observable<std::string>> AsObservable(CommandType type);
     void UnSubscribe() override;
 
-    void Send(CommandType type, const uint8_t *data, size_t size);
+    void Send(MetaMessage metadata);
     void Send(Buffer image);
     void Send(std::ifstream &file);
     void SetDataChannel(rtc::scoped_refptr<webrtc::DataChannelInterface> data_channel);
@@ -95,6 +95,7 @@ class DataChannelSubject : public webrtc::DataChannelObserver,
     std::map<CommandType, std::vector<std::shared_ptr<Observable<std::string>>>> observers_map_;
 
     void Send(const uint8_t *data, size_t size);
+    void Send(CommandType type, const uint8_t *data, size_t size);
 };
 
 #endif // DATA_CHANNEL_H_