refactor: use enable ipc flag

Author: TzuHuanTai

src/args.h

@@ -103,8 +103,7 @@ struct Args {
     int file_duration = 60;
 
     // ipc
-    std::string ipc_channel = "none";
-    int ipc_channel_mode = -1;
+    bool enable_ipc = false;
     std::string socket_path = "/tmp/pi-webrtc-ipc.sock";
 
     // webrtc

src/parser.cpp

@@ -15,12 +15,6 @@ static const std::unordered_map<std::string, int> v4l2_fmt_table = {
     {"i420", V4L2_PIX_FMT_YUV420},
 };
 
-static const std::unordered_map<std::string, int> ipc_mode_table = {
-    {"none", -1},
-    {"lossy", ChannelMode::Lossy},
-    {"reliable", ChannelMode::Reliable},
-};
-
 static const std::unordered_map<std::string, int> ae_metering_table = {
     {"centre", libcamera::controls::MeteringCentreWeighted},
     {"spot", libcamera::controls::MeteringSpot},
@@ -147,8 +141,8 @@ void Parser::ParseArgs(int argc, char *argv[], Args &args) {
         ("no-adaptive", bpo::bool_switch(&args.no_adaptive)->default_value(args.no_adaptive),
             "Disable WebRTC's adaptive resolution scaling. When enabled, "
             "the output resolution will remain fixed regardless of network or device conditions.")
-        ("ipc-channel-mode", bpo::value<std::string>(&args.ipc_channel)->default_value(args.ipc_channel),
-            "Set the WebRTC DataChannel mode for IPC relay: none, lossy, reliable.")
+        ("enable-ipc", bpo::bool_switch(&args.enable_ipc)->default_value(args.enable_ipc),
+            "Enable IPC relay using a WebRTC DataChannel, lossy (UDP-like) or reliable (TCP-like) based on client preference.")
         ("socket-path", bpo::value<std::string>(&args.socket_path)->default_value(args.socket_path),
             "Specifies the Unix domain socket path used to bridge messages between "
             "the WebRTC DataChannel and local IPC applications.")
@@ -242,7 +236,6 @@ void Parser::ParseArgs(int argc, char *argv[], Args &args) {
     args.af_mode = ParseEnum(afMode_table, args.autofocus_mode);
     args.af_range_mode = ParseEnum(afRange_table, args.af_range);
     args.af_speed_mode = ParseEnum(afSpeed_table, args.af_speed);
-    args.ipc_channel_mode = ParseEnum(ipc_mode_table, args.ipc_channel);
 
     if (sscanf(args.af_window.c_str(), "%f,%f,%f,%f", &args.af_window_x, &args.af_window_y,
                &args.af_window_width, &args.af_window_height) != 4) {

src/rtc/conductor.cpp

@@ -39,7 +39,7 @@ Conductor::Conductor(Args args)
     : args(args) {}
 
 Conductor::~Conductor() {
-    if (args.ipc_channel_mode > 0) {
+    if (ipc_server_) {
         ipc_server_->Stop();
     }
     audio_track_ = nullptr;
@@ -143,9 +143,8 @@ rtc::scoped_refptr<RtcPeer> Conductor::CreatePeerConnection(PeerConfig config) {
         }
         peer->CreateDataChannel(ChannelMode::Lossy);
         peer->CreateDataChannel(ChannelMode::Reliable);
-    } else if (args.ipc_channel_mode == ChannelMode::Lossy) {
+    } else if (args.enable_ipc) {
         SetupIpcDataChannel(peer, ChannelMode::Lossy);
-    } else if (args.ipc_channel_mode == ChannelMode::Reliable) {
         SetupIpcDataChannel(peer, ChannelMode::Reliable);
     }
 
@@ -313,7 +312,7 @@ void Conductor::InitializePeerConnectionFactory() {
 }
 
 void Conductor::InitializeIpcServer() {
-    if (args.ipc_channel_mode > 0) {
+    if (args.enable_ipc) {
         ipc_server_ = UnixSocketServer::Create(args.socket_path);
         ipc_server_->Start();
     }