Candidate solution for #477

Author: fbanados

validation/jinja2/validation/_segment_card.html

@@ -157,11 +157,11 @@
                                 {{ wrong_buttons.button_col(recording, csrf_token, request, language) }}
                                 {% if roles.is_linguist 
                                     and (recording.wrong_speaker or recording.wrong_word) 
-                                    and recording.issue_set.count() > 0 %}
-                                {% if recording.issue_set.count() == 1 %}
+                                    and recording.issue_set.filter(status="open").count() > 0 %}
+                                {% if recording.issue_set.filter(status="open").count() == 1 %}
                                 <a class="button button--neutral"
                                    data-cy="view-issue-button" 
-                                   href="{{ url('validation:issue_detail', language.code, recording.issue_set.get().id)}}">See Issue...</a>
+                                   href="{{ url('validation:issue_detail', language.code, recording.issue_set.filter(status="open").get().id)}}">See Issue...</a>
                                 {% else %}
                                 <div class="dropdown">
                                     <button class="button button--neutral dropdown-toggle" data-cy="view-issue-button" data-toggle="dropdown" aria-expanded="false">Issues...</button>

validation/migrations/0058_alter_historicalphrase_osid_alter_phrase_osid.py

@@ -0,0 +1,33 @@
+# Generated by Django 4.2.24 on 2025-09-22 16:24
+
+from django.db import migrations, models
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ("validation", "0057_alter_historicalphrase_history_relation"),
+    ]
+
+    operations = [
+        migrations.AlterField(
+            model_name="historicalphrase",
+            name="osid",
+            field=models.CharField(
+                blank=True,
+                help_text="Typically, this is the os##### for Tsuut'ina recordings",
+                max_length=16,
+                null=True,
+            ),
+        ),
+        migrations.AlterField(
+            model_name="phrase",
+            name="osid",
+            field=models.CharField(
+                blank=True,
+                help_text="Typically, this is the os##### for Tsuut'ina recordings",
+                max_length=16,
+                null=True,
+            ),
+        ),
+    ]

validation/models.py

@@ -332,6 +332,7 @@ class Phrase(models.Model):
     osid = models.CharField(
         help_text="Typically, this is the os##### for Tsuut'ina recordings",
         null=True,
+        blank=True,
         max_length=16,
     )
 

validation/views.py

@@ -43,7 +43,7 @@
 from django.contrib.auth.views import LoginView, LogoutView
 from django.core.files.uploadedfile import InMemoryUploadedFile
 from django.core.paginator import Paginator
-from django.db.models import Q, QuerySet, Count, Case, When, IntegerField, F
+from django.db.models import Q, QuerySet, Count, Case, When, IntegerField, F, Max
 from django.http import (
     HttpResponse,
     HttpResponseBadRequest,
@@ -1674,13 +1674,18 @@ def handle_save_issue_with_recording(form, issue, request, language):
             new_phrase = Phrase(
                 field_transcription=new_word,
                 transcription=new_word,
-                translation="",
-                kind="Sentence" if " " in new_word else "Word",
+                translation="[]",
+                kind=Phrase.SENTENCE if " " in new_word else Phrase.WORD,
                 date=datetime.datetime.now(),
+                language=rec.phrase.language,
                 modifier=str(request.user),
+                display_order=Phrase.objects.aggregate(Max("display_order", default=0))[
+                    "display_order__max"
+                ]
+                + 1,  # Place last
             )
             new_phrase.save()
-        rec.phrase_id = new_phrase.id
+        rec.phrase = new_phrase
 
     rec.wrong_word = False
     rec.wrong_speaker = False
@@ -1710,7 +1715,7 @@ def handle_save_issue_with_phrase(form, issue, request, language):
     if translation:
         phrase.translation = translation
 
-    phrase.status = "linked"
+    phrase.status = Phrase.LINKED
     phrase.modifier = str(request.user)
     phrase.date = datetime.datetime.now()
     phrase.save()