Add dummies for missing functions and fix existing ones in Alma ILS driver

Author: Stefan Weil

module/VuFind/src/VuFind/ILS/Driver/Alma.php

@@ -447,6 +447,64 @@ public function getHolding($id, $patron = null, array $options = [])
         return $results;
     }
 
+    /**
+     * Get Departments
+     *
+     * Obtain a list of departments for use in limiting the reserves list.
+     *
+     * @return array An associative array with key = dept. ID, value = dept. name.
+     */
+    public function getDepartments()
+    {
+        return ['Rechtswissenschaft', 'Volkswirtschaftslehre'];
+    }
+
+    /**
+     * Get Instructors
+     *
+     * Obtain a list of instructors for use in limiting the reserves list.
+     *
+     * @return array An associative array with key = ID, value = name.
+     */
+    public function getInstructors()
+    {
+        return ['Jörg', 'Philipp', 'Stefan'];
+    }
+
+    /**
+     * Get New Items
+     *
+     * Retrieve the IDs of items recently added to the catalog.
+     *
+     * @param int $page    Page number of results to retrieve (counting starts at 1)
+     * @param int $limit   The size of each page of results to retrieve
+     * @param int $daysOld The maximum age of records to retrieve in days (max. 30)
+     * @param int $fundId  optional fund ID to use for limiting results (use a value
+     * returned by getFunds, or exclude for no limit); note that "fund" may be a
+     * misnomer - if funds are not an appropriate way to limit your new item
+     * results, you can return a different set of values from getFunds. The
+     * important thing is that this parameter supports an ID returned by getFunds,
+     * whatever that may mean.
+     *
+     * @return array       Associative array with 'count' and 'results' keys
+     *
+     * @SuppressWarnings(PHPMD.UnusedFormalParameter)
+     */
+    public function getNewItems($page, $limit, $daysOld, $fundId = null)
+    {
+        return ['count' => 0, 'results' => []];
+
+        // Pick a random number of results to return -- don't exceed limit or 30,
+        // whichever is smaller (this can be pretty slow due to the random ID code).
+        $results = $this->config['Records']['new_items']
+            ?? $this->getRandomBibIds(30);
+        $retVal = ['count' => count($results), 'results' => []];
+        foreach ($results as $result) {
+            $retVal['results'][] = ['id' => $result];
+        }
+        return $retVal;
+    }
+
     /**
      * Check if request is valid
      *
@@ -1667,7 +1725,7 @@ public function findReserves($courseID, $instructorID, $departmentID)
                 $listsBase . '/' . rawurlencode($listId) . '/citations'
             );
             foreach ($listXML as $citation) {
-                $reserves[$citation->id] = $citation->metadata;
+                $reserves[(string)$citation->id] = $citation->metadata;
             }
         }
         return $reserves;