Fix runtime exceptions

Author: Stefan Weil

module/VuFind/src/VuFind/ILS/Connection.php

@@ -185,7 +185,7 @@ public function __construct(
         \Laminas\Config\Config $config,
         \VuFind\ILS\Driver\PluginManager $driverManager,
         \VuFind\Config\PluginManager $configReader,
-        \Laminas\Http\Request $request = null
+        ?\Laminas\Http\Request $request = null
     ) {
         if (!isset($config->driver)) {
             throw new \Exception('ILS driver setting missing.');
@@ -288,7 +288,7 @@ protected function hasNoILSFailover()
      *
      * @return bool
      */
-    protected function failOverToNoILS(\Exception $e = null)
+    protected function failOverToNoILS(?\Exception $e = null)
     {
         // If the exception is caused by a configuration error, the administrator
         // needs to fix it, but failing over to NoILS will mask the error and cause
@@ -1218,7 +1218,7 @@ public function getStatus($id)
         $status = $this->__call('getStatus', [$id]);
 
         // parse availability and status to AvailabilityStatus object
-        return array_map($this->getStatusParser(), $status);
+        return array_map($this->getStatusParser(), $status ?: []);
     }
 
     /**

module/VuFind/src/VuFind/ILS/Driver/Demo.php

@@ -208,7 +208,7 @@ public function __construct(
         \VuFind\Date\Converter $dateConverter,
         SearchService $ss,
         $sessionFactory,
-        HttpRequest $request = null
+        ?HttpRequest $request = null
     ) {
         $this->dateConverter = $dateConverter;
         $this->searchService = $ss;
@@ -471,7 +471,7 @@ public function getAccountBlocks($patron)
      *
      * @return array
      */
-    protected function getRandomHolding($id, $number, array $patron = null)
+    protected function getRandomHolding($id, $number, ?array $patron = null)
     {
         $status = $this->getFakeStatus();
         $location = $this->getFakeLoc();
@@ -730,7 +730,7 @@ protected function getSession($patron = null)
      *
      * @SuppressWarnings(PHPMD.UnusedFormalParameter)
      */
-    protected function getSimulatedStatus($id, array $patron = null)
+    protected function getSimulatedStatus($id, ?array $patron = null)
     {
         $id = (string)$id;
 
@@ -872,7 +872,7 @@ protected function getNotesAndSummary(int $itemNum): array
      * id, availability (boolean), status, location, reserve, callnumber,
      * duedate, number, barcode.
      */
-    public function getHolding($id, array $patron = null, array $options = [])
+    public function getHolding($id, ?array $patron = null, array $options = [])
     {
         $this->checkIntermittentFailure();