Skip to content

Commit 3582c81

Browse files
authored
Merge pull request #77 from UBC-MDS/codecov
Codecov integration
2 parents cf77575 + 534c8bf commit 3582c81

File tree

2 files changed

+14
-6
lines changed

2 files changed

+14
-6
lines changed

.github/workflows/build.yml

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,15 @@ jobs:
3131
pip install -e ".[tests]"
3232
- name: Run tests
3333
run: |
34-
pytest --cov=sudoku_validation --cov-report=term --cov-branch
34+
pytest --cov=sudoku_validation --cov-report=term --cov-report=xml --cov-branch
35+
36+
- name: Upload coverage to Codecov
37+
uses: codecov/codecov-action@v4
38+
with:
39+
files: ./coverage.xml
40+
token: ${{ secrets.CODECOV_TOKEN }}
41+
fail_ci_if_error: true
42+
3543
- name: Run style checks
3644
run: |
3745
python -m pip install ruff

tests/unit/test_column_validation.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -152,7 +152,7 @@ def test_column_validation_invalid_board_wrong_columns():
152152

153153
def test_column_validation_invalid_board_invalid_value_zero():
154154
"""
155-
Test column_validation with board containing invalid value (0 is outside 1-9 range).
155+
Test column_validation with board containing invalid value at row 0, column 0 (0 is outside 1-9 range).
156156
"""
157157
invalid_board_invalid_value = [
158158
[0, 2, 3, 4, 5, 6, 7, 8, 9],
@@ -171,7 +171,7 @@ def test_column_validation_invalid_board_invalid_value_zero():
171171

172172
def test_column_validation_invalid_board_invalid_value_ten():
173173
"""
174-
Test column_validation with board containing invalid value (10 is outside 1-9 range).
174+
Test column_validation with board containing invalid value at row 0, column 8 (10 is outside 1-9 range).
175175
"""
176176
invalid_board_invalid_value_2 = [
177177
[1, 2, 3, 4, 5, 6, 7, 8, 10],
@@ -190,7 +190,7 @@ def test_column_validation_invalid_board_invalid_value_ten():
190190

191191
def test_column_validation_invalid_board_negative_values():
192192
"""
193-
Test column_validation with board containing negative values.
193+
Test column_validation with board containing negative values at row 0, column 0 (-1 is outside 1-9 range).
194194
"""
195195
invalid_board_negative_values = [
196196
[-1, 2, 3, 4, 5, 6, 7, 8, 9],
@@ -209,7 +209,7 @@ def test_column_validation_invalid_board_negative_values():
209209

210210
def test_column_validation_invalid_board_duplicate_values_1():
211211
"""
212-
Test column_validation with board containing duplicate values (example 1).
212+
Test column_validation with board containing duplicate values at row 0, column 0 and row 1, column 0 (1 is duplicated).
213213
"""
214214
invalid_board_duplicate_values = [
215215
[1, 2, 3, 4, 4, 6, 7, 8, 9],
@@ -227,7 +227,7 @@ def test_column_validation_invalid_board_duplicate_values_1():
227227

228228
def test_column_validation_invalid_board_duplicate_values_2():
229229
"""
230-
Test column_validation with board containing duplicate values (example 2).
230+
Test column_validation with board containing duplicate values at row 0, column 4 and row 1, column 0 (1 is duplicated).
231231
"""
232232
board_example_5 = [
233233
[9, 6, 3, 1, 7, 4, 2, 5, 8],

0 commit comments

Comments
 (0)