Major fix to repo building, package deps, and setup scripts

Author: Roozki

.github/workflows/test.yaml

@@ -5,22 +5,33 @@ jobs:
     runs-on: ubuntu-22.04
     steps:
      - uses: actions/checkout@v4
-     - run: |
+     - name: enviroment setupg
+       run: |
          export ROVERFLAKE_ROOT="${GITHUB_WORKSPACE}"
          yes | ./setup_scripts/setup_everything_common.sh
+     - name: build
+       run: |
+         cd $ROVERFLAKE_ROOT
+         echo $ROS_DISTRO
+         source /opt/ros/humble/setup.bash
+         echo $ROS_DISTRO
+         colcon build --symlink-install
      - name: Notify Discord (success)
        if: ${{ success() }}
        uses: appleboy/[email protected]
        with:
-        webhook_id: ${{ secrets.DISCORD_BOT_WEBHOOK_URL }} # it also accepts full URL
+        webhook_id: ${{ secrets.DISCORD_BOT_WEBHOOK_ID }} # it also accepts full URL
+        webhook_token: ${{ secrets.DISCORD_BOT_WEBHOOK_TOKEN }} # it also accepts full URL
         message: |
               :) ${{ github.repository }} on `${{ github.ref_name }}`
               ${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}
-     - name: Notify Discord (success)
+     - name: Notify Discord (failure)
        if: ${{ failure() }}
        uses: appleboy/[email protected]
        with:
-        webhook_id: ${{ secrets.DISCORD_BOT_WEBHOOK_URL }} # it also accepts full URL
+        webhook_id: ${{ secrets.DISCORD_BOT_WEBHOOK_ID }} # it also accepts full URL
+        webhook_token: ${{ secrets.DISCORD_BOT_WEBHOOK_TOKEN }} # it also accepts full URL
         message: |
               _you have saddened me ${{ github.actor }}_
-              ${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}
+              ${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}
+  

setup_scripts/setup_everything_common.sh

@@ -23,7 +23,6 @@ echo Will install ros2 humble, vscode, btop, tmux and other useful tools.
 echo This script will NOT install discord. run install-discord.sh if you want discord.
 sleep 1.0
 echo starting with ros2...
-exit 1
 
 #sudo apt update
 cd $ROVERFLAKE_ROOT/setup_scripts/
@@ -63,7 +62,7 @@ source /opt/ros/humble/setup.bash
 #install ros2 packages
 sudo rosdep init
 rosdep update
-rosdep install --from-paths src -y --ignore-src
+rosdep install --from-paths src -y --ignore-src --skip-keys="serial"
 # for package in "${ros_packages_to_install[@]}"; do
 #     if is_package_installed "$package"; then
 #         echo "Package '$package' is already installed."

src/arm_control/package.xml

@@ -38,6 +38,10 @@
   <exec_depend>robot_state_publisher</exec_depend>
   <exec_depend>tf2_ros</exec_depend>
 
+  <depend>rover_utils</depend> 
+  <depend>moteus_msgs</depend> 
+
+
   <test_depend>ament_cmake_gtest</test_depend>
   <test_depend>ament_lint_auto</test_depend>
   <test_depend>ament_lint_common</test_depend>

src/arm_hardware_interface/package.xml

@@ -19,7 +19,7 @@
   <depend>arm_control</depend>
 
 <!-- Rosdep fails with the following: -->
-  <!-- <depend>serial</depend> -->
+  <depend>serial</depend>
 
   <export>
     <build_type>ament_cmake</build_type>

src/cameras_cpp/package.xml

@@ -8,6 +8,8 @@
   <license>TODO: License declaration</license>
 
   <buildtool_depend>ament_cmake</buildtool_depend>
+  <!-- <depend>rover_utils</depend> -->
+  <build_export_depend>rover_utils</build_export_depend>
 
   <test_depend>ament_lint_auto</test_depend>
   <test_depend>ament_lint_common</test_depend>

src/rover_hmi/CMakeLists.txt

@@ -1,4 +1,4 @@
-cmake_minimum_required(VERSION 3.8)
+cmake_minimum_required(VERSION 3.10)
 project(rover_hmi)
 
 if(CMAKE_COMPILER_IS_GNUCXX OR CMAKE_CXX_COMPILER_ID MATCHES "Clang")

src/rover_launchers/CMakeLists.txt

@@ -1,4 +1,4 @@
-cmake_minimum_required(VERSION 3.8)
+cmake_minimum_required(VERSION 3.10)
 project(rover_launchers)
 
 if(CMAKE_COMPILER_IS_GNUCXX OR CMAKE_CXX_COMPILER_ID MATCHES "Clang")

src/rover_manager/package.xml

@@ -14,9 +14,8 @@
 
   <depend>rclcpp</depend>
   <depend>rover_msgs</depend>
-
-  
-
+  <build_export_depend>serial</build_export_depend> 
+  <build_export_depend>rover_utils</build_export_depend> 
 
   <export>
     <build_type>ament_cmake</build_type>

src/rover_samples/rv_sample_package/package.xml

@@ -12,6 +12,8 @@
   <test_depend>ament_lint_auto</test_depend>
   <test_depend>ament_lint_common</test_depend>
 
+  <build_export_depend>rover_utils</build_export_depend>
+
   <depend>rclcpp</depend>
   <depend>sensor_msgs</depend>
 

src/rover_sounds/CMakeLists.txt

@@ -1,4 +1,4 @@
-cmake_minimum_required(VERSION 3.8)
+cmake_minimum_required(VERSION 3.10)
 project(rover_sounds)
 
 if(CMAKE_COMPILER_IS_GNUCXX OR CMAKE_CXX_COMPILER_ID MATCHES "Clang")