@@ -9,10 +9,16 @@ We are actively encouraging users to ask questions and start discussions in the
99[ discussions tab] of this repository. Does something seem like it's broken?
1010Please go ahead and [ open an issue] !
1111
12- The [ website] pages are open to contributions but they will need to be reviewed
13- by a member or associate member of ARC. We might be slow to approve new tool
14- suggestions (since we'll probably want to discuss them first) but don't let that
15- put you off creating an issue.
12+ The template and [ website] pages are open to contributions! But they will need
13+ to be reviewed by a member or associate member of ARC.
14+
15+ We will probably be slow to approve new tool suggestions (since we'll probably
16+ want to discuss them first) but don't let that put you off creating an issue!
17+
18+ Any opinionated changes should be approved by at least two reviewers who are
19+ members or associate members of ARC. Pull-request authors are trusted to add two
20+ reviewers to anything that they think might be opinionated. If a reviewer adds
21+ a second reviewer, please wait for both to approve before merging.
1622
1723## Development workflow
1824
@@ -24,8 +30,9 @@ To contribute a change, please:
2430 the tests pass if you modified the template (` pytest -s ` ).
25313 . Open a _ pull request_ (PR) with changes.
26324 . Ask someone who did not contribute to the PR from [ @UCL-ARC/collaborations ]
27- to review it.
28- 5 . If approved with no comments, then the reviewer will merge the PR.
33+ to review it. If it should have two reviewers, you can also request a review
34+ from [ @UCL-ARC/collaborations-python-tooling ] and add the ` needs-2-reviewers ` label.
35+ 5 . If approved with no comments, then the last approving reviewer should merge the PR.
29366 . If changes are requested, the PR author should address the comments, and then
3037 ask for review again.
3138
@@ -87,6 +94,7 @@ See the [jekyll docs] for more info.
8794[ Research software engineers ] : https://society-rse.org/about/history
8895[ pre-commit ] : https://pre-commit.com
8996[ @UCL-ARC/collaborations ] : https://github.com/orgs/UCL-ARC/teams/collaborations
97+ [ @UCL-ARC/collaborations-python-tooling ] : https://github.com/orgs/UCL-ARC/teams/collaborations-python-tooling
9098[ uv tool ] : https://docs.astral.sh/uv/guides/tools
9199[ Install jekyll ] : https://jekyllrb.com/docs/installation
92100[ jekyll docs ] : https://jekyllrb.com/docs
0 commit comments