Skip to content

Commit 6cc97a3

Browse files
removed some functions that made no sense
These were probably copy-paste from the 1D version, but don't make sense in 2D or 3D.
1 parent 00c2b49 commit 6cc97a3

File tree

4 files changed

+12
-0
lines changed

4 files changed

+12
-0
lines changed

src/buildblock/ArrayFilter2DUsingConvolution.cxx

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,8 @@ ArrayFilter2DUsingConvolution<elemT>::is_trivial() const
4747
|| (filter_coefficients.get_length() == 1 && filter_coefficients.get_min_index() == 0 && filter_coefficients[0][0] == 1);
4848
}
4949

50+
#if 0
51+
// commented out as it does not make sense to have a 1D IndexRange for a 2D filter
5052
template <typename elemT>
5153
Succeeded
5254
ArrayFilter2DUsingConvolution<elemT>::get_influencing_indices(IndexRange<1>& influencing_index_range,
@@ -70,6 +72,7 @@ ArrayFilter2DUsingConvolution<elemT>::get_influenced_indices(IndexRange<1>& infl
7072
output_index_range.get_max_index() + filter_coefficients.get_max_index());
7173
return Succeeded::yes;
7274
}
75+
#endif
7376

7477
template <typename elemT>
7578
void

src/buildblock/ArrayFilter3DUsingConvolution.cxx

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,8 @@ ArrayFilter3DUsingConvolution<elemT>::is_trivial() const
5959
&& filter_coefficients[0][0][0] == 1);
6060
}
6161

62+
#if 0
63+
// commented out as it does not make sense to have a 1D IndexRange for a 2D filter
6264
template <typename elemT>
6365
Succeeded
6466
ArrayFilter3DUsingConvolution<elemT>::get_influencing_indices(IndexRange<1>& influencing_index_range,
@@ -82,6 +84,7 @@ ArrayFilter3DUsingConvolution<elemT>::get_influenced_indices(IndexRange<1>& infl
8284
output_index_range.get_max_index() + filter_coefficients.get_max_index());
8385
return Succeeded::yes;
8486
}
87+
#endif
8588

8689
#if 1
8790
template <typename elemT>

src/include/stir/ArrayFilter2DUsingConvolution.h

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,9 +40,12 @@ class ArrayFilter2DUsingConvolution : public ArrayFunctionObject_2ArgumentImplem
4040

4141
bool is_trivial() const override;
4242

43+
#if 0
44+
// commented out as it does not make sense to have a 1D IndexRange for a 2D filter
4345
virtual Succeeded get_influencing_indices(IndexRange<1>& influencing_indices, const IndexRange<1>& output_indices) const;
4446

4547
virtual Succeeded get_influenced_indices(IndexRange<1>& influenced_indices, const IndexRange<1>& input_indices) const;
48+
#endif
4649

4750
private:
4851
Array<2, float> filter_coefficients;

src/include/stir/ArrayFilter3DUsingConvolution.h

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,9 +40,12 @@ class ArrayFilter3DUsingConvolution : public ArrayFunctionObject_2ArgumentImplem
4040

4141
bool is_trivial() const override;
4242

43+
#if 0
44+
// commented out as it does not make sense to have a 1D IndexRange for a 2D filter
4345
virtual Succeeded get_influencing_indices(IndexRange<1>& influencing_indices, const IndexRange<1>& output_indices) const;
4446

4547
virtual Succeeded get_influenced_indices(IndexRange<1>& influenced_indices, const IndexRange<1>& input_indices) const;
48+
#endif
4649

4750
private:
4851
Array<3, float> filter_coefficients;

0 commit comments

Comments
 (0)