make coincidence_time_window arg of randoms_from_singles default

we now have it in Scanner

Author: KrisThielemans

src/data_buildblock/randoms_from_singles.cxx

@@ -30,13 +30,11 @@
 START_NAMESPACE_STIR
 
 void randoms_from_singles(ProjData& proj_data, const SinglesRates& singles,
-                          const float coincidence_time_window, float isotope_halflife)
+                          float coincidence_time_window, float isotope_halflife)
 {
   const auto& scanner = *proj_data.get_proj_data_info_sptr()->get_scanner_ptr();
   if (coincidence_time_window <= 0.F)
-    {
-      coincidence_time_window =scanner.get_coincidence_window_width_in_ps() / 1e12F;
-    }
+    coincidence_time_window = scanner.get_coincidence_window_width_in_ps() / 1e12F;
   if (isotope_halflife <= 0.F)
     isotope_halflife = proj_data.get_exam_info().get_radionuclide().get_half_life();
 

src/include/stir/data/randoms_from_singles.h

@@ -27,7 +27,16 @@ class SinglesRates;
 
 /*!
   \ingroup singles_buildblock
-  \brief Estimate randoms from singles
+  \brief Estimate randoms from singles (RFS)
+
+  \param[in,out] proj_data
+     Projection data to store output. It needs to be properly initialised with sizes etc.
+     If \a coincidence_time_window or
+     \a radionuclide_halflife are invalid, they will be determined from the \a proj_data.
+  \param[in] singles
+     Input value for RFS
+  \param[in] coincidence_time_window Scanner coincidence window (in secs). Deprecated.
+  \param[in] radionuclide_halflife half-life. Deprecated.
 
   This uses the formula \f$ R_{ij}= \tau S_i S_j \f$ (with \f$\tau\f$ the \c coincidence_time_window)
   for finding the randoms-rate in terms of the
@@ -59,6 +68,7 @@ class SinglesRates;
 
   \todo Dead-time is currently completely ignored.
 */
-void randoms_from_singles(ProjData& proj_data, const SinglesRates& singles, const float coincidence_time_window, float isotope_halflife=-1.F);
+void randoms_from_singles(ProjData& proj_data, const SinglesRates& singles,
+                          float coincidence_time_window=-1.F, float radionuclide_halflife=-1.F);
 
 END_NAMESPACE_STIR

src/utilities/construct_randoms_from_GEsingles.cxx

@@ -84,9 +84,7 @@ int main(int argc, char **argv)
               output_file_name);
 
   GE::RDF_HDF5::SinglesRatesFromGEHDF5  singles(input_filename);
-  const float coincidence_time_window = proj_data_info_sptr->get_coincidence_window_in_pico_sec() / 1e12F;
-  const float isotope_halflife = exam_info_sptr->get_radionuclide().get_half_life();
 
-  randoms_from_singles(proj_data, singles, coincidence_time_window, isotope_halflife);
+  randoms_from_singles(proj_data, singles);
   return EXIT_SUCCESS;
 }