Skip to content

Add SDV as dependency and update requirements file#1758

Merged
tamuri merged 9 commits intomasterfrom
tamuri/sdv-dep
Nov 26, 2025
Merged

Add SDV as dependency and update requirements file#1758
tamuri merged 9 commits intomasterfrom
tamuri/sdv-dep

Conversation

@tamuri
Copy link
Copy Markdown
Collaborator

@tamuri tamuri commented Nov 20, 2025

Resolves #1755. I have avoided updating the other dependencies, especially numpy and pandas as these have big effect on the epi modules. However, had to update virtualenv because sdv requires a more recent version of platformdirs.

Also, dev.txt is also constrained by base.txt when using pip-compile to ensure consistency.

@marghe-molaro - the resolved version of sdv (1.20.1) was the most recent that doesn't disturb the other packages. Can you check these requirement still work for your emulator, please? You can create a new conda environment to test.

@tamuri tamuri requested a review from marghe-molaro November 20, 2025 14:19
@tamuri tamuri added the dependencies Pull requests that update a dependency file label Nov 20, 2025
@marghe-molaro
Copy link
Copy Markdown
Collaborator

Hi @tamuri, unfortunately I get the following errors:

sdv.errors.VersionError: You are currently on SDV version 1.20.1 but this synthesizer was created on version 1.22.1. Downgrading your SDV version is not supported.

Attaching to this message the conda environment on which the emulator branch is currently working.

hack_tlo_and_SDV_environment.yml

@tamuri
Copy link
Copy Markdown
Collaborator Author

tamuri commented Nov 20, 2025

To confirm: the saved file was created using version 1.22.1 but the version you're running is 1.24.1? Meaning that newer version can read files created by an older version?

@tamuri
Copy link
Copy Markdown
Collaborator Author

tamuri commented Nov 20, 2025

Pinned sdv to 1.24.1. Please try again @marghe-molaro.

@tamuri tamuri self-assigned this Nov 21, 2025
@marghe-molaro
Copy link
Copy Markdown
Collaborator

Confirming that this new environment is now working fine, many thanks @tamuri

@tamuri
Copy link
Copy Markdown
Collaborator Author

tamuri commented Nov 24, 2025

Thanks for checking - please approve!

@tamuri tamuri merged commit d4e87a0 into master Nov 26, 2025
64 of 66 checks passed
@tamuri tamuri deleted the tamuri/sdv-dep branch November 26, 2025 17:39
tamuri added a commit that referenced this pull request Feb 3, 2026
tamuri added a commit that referenced this pull request Feb 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add SDV dependency to requirements

2 participants