Pass module name with consumables when tracking individual histories#1786
Merged
Pass module name with consumables when tracking individual histories#1786
Conversation
Collaborator
Author
|
Only collect data to dispatch if there are any listeners, to ensure consumable tests pass |
Collaborator
Author
|
@tamuri tests are passing locally |
tamuri
reviewed
Jan 21, 2026
Simplify logic Co-authored-by: Asif Tamuri <tamuri@gmail.com>
tamuri
approved these changes
Jan 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix dispatching of consumable access when tracking individual histories: it should be module's name, not module, that is passed to the dispatcher.
Additionally include small style fixes to the consumable logging (no need to log HSI name and module during cons accessed as this is redundant, and create a dictionary of useful info for each cons access rather than attaching cons access counter to info's name).