Correct staff count log

[marghe-molaro]

When logging the number of staff, the log_number_of_staff function compares capabilities_today - which rescales the _daily_capabilities by the capabilities_coefficient - with _daily_capabilities_per_staff - which does not. Unless I am missing something obvious, this would therefore lead to an incorrect estimation of the staff count.

As raised in Issue #1618, it seems dangerous to dynamically incorporate the capabilities_coefficient via capabilities_today; the rescaling should occur once, upon initialisation, to avoid issues such as this.

[tbhallett]

Thanks. Good spot.

I agree with your diagnosis here.

I also like your prescription:

... the rescaling (by capabilities_coefficient) should occur once, upon initialisation, (as opposed to day-by-day) to avoid issues such as this.

We could merge this now. Or, should we make this change that you propose here?

[marghe-molaro]

Could we merge this for now so that this fix is in, and then I'll get to Issue #1618 asap?

[tbhallett]

Sure. Let’s merge now.