revert: "reverse settings"

This reverts commit 7feccb1.

Author: feildmaster

changelog.md

@@ -1,5 +1,9 @@
 # UnderScript Changelog
 
+## Version 0.63.1 (2025-07-02)
+1. Reverted "reversed settings"
+  - They were completely broken
+
 ## Version 0.63.0 (2025-07-01)
 Over 5000 line changes~ (in 250 files)
 ### Features

lang/en/settings.json

@@ -2,7 +2,7 @@
   "announce": "Announcement",
   "announce.friendsOnly": "Friends Only",
   "announce.notSelf": "Ignore Self",
-  "autocomplete": "Disable Autocomplete",
+  "autocomplete": "Visual Autocomplete",
   "autocomplete.friends": "Autocomplete: Online Friends Only",
   "broadcast": "Disable Broadcast Toast",
   "card.name.english": "Force English for card names",
@@ -63,13 +63,13 @@
   ],
   "fishday": "Disable April Fools Jokes",
   "fishday.note": "Disables *almost* everything.",
-  "friend.add": "Disable adding friends without refreshing",
+  "friend.add": "Add friends without refreshing",
   "friend.auto": "Disable",
   "friend.auto.ignore": "Include ignored chat users",
   "friend.auto.silent": "Silent",
   "friend.background": "Remove friends without refreshing",
   "friend.decline": "Disable decline all button",
-  "friend.online": "Disable online friends",
+  "friend.online": "Enable online friends",
   "friend.request": "Disable Friend Request Notifications",
   "friendship": "Disable Collect All",
   "friendship.notification": "Disable Friendship Notification",
@@ -88,12 +88,12 @@
   "import.shiny": "Prefer Shiny",
   "key.any": "Press Any Key...",
   "key.bind": "Click to bind",
-  "large.avatar": "Disable Large Icon mode",
+  "large.avatar": "Large Icon mode",
   "library.scrollwheel": "Disable Scrolling Collection with Mousewheel",
-  "links": "Disable Improved Link Detection",
+  "links": "Use Original Link Detection",
   "map.duplicate": "Duplicate value, not updated! Click here to reset.",
   "minigame": "Disable",
-  "minigame.keys": "Disable WASD",
+  "minigame.wasd": "Use WASD",
   "note.refresh": "Will require you to refresh the page.",
   "page.chat": "Chat",
   "page.friends": "Friends",
@@ -105,9 +105,9 @@
   "ping": "Disable Chat Ping {{STYLE:highlight|(highlighting)}}",
   "ping.global": "Only open chats",
   "ping.on": "On",
-  "ping.toast": "Disable ping toasts",
+  "ping.toast": "Enable ping toasts",
   "quest.highlight": "Disable Quest Highlight",
-  "safelink": "Disabled",
+  "safelink": "Enabled",
   "safelink.trust": "Trust $1",
   "skins.basic": "Force Basic Card Skins",
   "skins.breaking": "Breaking Card Art Behavior",
@@ -125,11 +125,11 @@
     "No"
   ],
   "title": "UnderScript Configuration",
-  "toast.bundle": "Disable bundle toast",
-  "toast.cards": "Disable new Card toast",
-  "toast.emotes": "Disable emote toast",
-  "toast.pass": "Disable quest pass toast",
-  "toast.skins": "Disable skin toast",
+  "toast.bundle": "Enable bundle toast",
+  "toast.cards": "Enable new Card toast",
+  "toast.emotes": "Enable emote toast",
+  "toast.pass": "Enable quest pass toast",
+  "toast.skins": "Enable skin toast",
   "update": "Disable Auto Updates",
   "update.frequency": "Update Frequency",
   "update.frequency.option": [

src/base/chat/autocomplete.js

@@ -9,7 +9,7 @@ import Translation from 'src/structures/constants/translation.js';
 const setting = settings.register({
   name: Translation.Setting('autocomplete'),
   key: 'underscript.autocomplete',
-  data: { reverse: true },
+  default: true,
   page: 'Chat',
 });
 

src/base/chat/largeIconMode.js

@@ -8,7 +8,7 @@ import style from 'src/utils/style.js';
 const setting = settings.register({
   name: Translation.Setting('large.avatar'),
   key: 'underscript.chat.largeIcons',
-  data: { reverse: true },
+  default: true,
   page: 'Chat',
   onChange: update,
 });

src/base/chat/tag.friend.js

@@ -5,15 +5,13 @@ import { infoToast } from 'src/utils/2.toasts.js';
 import style from 'src/utils/style.js';
 
 const tag = settings.register({
-  // TODO: Translation
   name: 'Highlight <span class="friend">friends</span> in chat',
   key: 'underscript.tag.friend',
-  data: { reverse: true },
+  default: true,
   page: 'Chat',
 });
 
 const color = settings.register({
-  // TODO: Translation
   name: 'Friend color',
   key: 'underscript.tag.friend.color',
   type: 'color',
@@ -23,16 +21,13 @@ const color = settings.register({
   reset: true,
 });
 
-const friendColor = style.add();
-
 setColor(color.value());
 
 let toast;
 function processMessage(message, room) {
   if (!tag.value()) return;
   if (global('isFriend')(message.user.id)) {
     if (!toast) {
-      // TODO: Translation
       toast = infoToast('<span class="friend">Friends</span> are now highlighted in chat.', 'underscript.notice.highlighting', '1');
     }
     $(`#${room} #message-${message.id} .chat-user`).addClass('friend');
@@ -52,5 +47,5 @@ eventManager.on('Chat:getMessage', function tagFriends(data) {
 });
 
 function setColor(newColor) {
-  friendColor.replace(`.friend { color: ${newColor} !important; }`);
+  style.add(`.friend { color: ${newColor} !important; }`);
 }

src/base/chat/toast.js

@@ -13,13 +13,13 @@ const category = Translation.Setting('category.chat.ping');
 const setting = settings.register({
   name: Translation.Setting('ping.toast'),
   key: 'underscript.enable.pingToast',
-  data: { reverse: true },
+  default: true,
   category,
   page: 'Chat',
 });
 
 export const globalPing = settings.register({
-  name: Translation.Setting('ping.global'),
+  name: Translation.Setting('ping.toast'),
   key: 'underscript.enable.ping.global',
   category,
   page: 'Chat',

src/base/chat/trustedLink.js

@@ -13,7 +13,7 @@ const base = {
 const setting = settings.register({
   ...base,
   name: Translation.Setting('safelink'),
-  data: { reverse: true },
+  default: true,
   key: 'underscript.enabled.safelink',
 });
 

src/base/friends/add.js

@@ -11,7 +11,7 @@ import style from 'src/utils/style';
 const setting = settings.register({
   name: Translation.Setting('friend.add'),
   key: 'underscript.friend.add',
-  data: { reverse: true },
+  default: true,
   page: 'Friends',
 });
 

src/base/friends/online.js

@@ -9,7 +9,7 @@ import Translation from 'src/structures/constants/translation.ts';
 const setting = settings.register({
   name: Translation.Setting('friend.online'),
   key: 'underscript.enable.onlinefriends',
-  data: { reverse: true },
+  default: true,
   page: 'Friends',
 });
 let popper;

src/base/home/newContent.js

@@ -5,36 +5,43 @@ import onPage from 'src/utils/onPage.js';
 import cleanData from 'src/utils/cleanData.js';
 import Translation from 'src/structures/constants/translation.ts';
 
-const base = {
-  data: { reverse: true },
-  refresh: () => onPage(''),
-  category: Translation.CATEGORY_HOME,
-};
+const category = Translation.CATEGORY_HOME;
+
 const bundle = settings.register({
-  ...base,
   name: Translation.Setting('toast.bundle'),
   key: 'underscript.toast.bundle',
+  default: true,
+  refresh: () => onPage(''),
+  category,
   // TODO: Always hide bundles?
 });
 const skin = settings.register({
-  ...base,
   name: Translation.Setting('toast.skins'),
   key: 'underscript.toast.skins',
+  default: true,
+  refresh: () => onPage(''),
+  category,
 });
 const emotes = settings.register({
-  ...base,
   name: Translation.Setting('toast.emotes'),
   key: 'underscript.toast.emotes',
+  default: true,
+  refresh: () => onPage(''),
+  category,
 });
 const quest = settings.register({
-  ...base,
   name: Translation.Setting('toast.pass'),
   key: 'underscript.toast.quests',
+  default: true,
+  refresh: () => onPage(''),
+  category,
 });
 const card = settings.register({
-  ...base,
   name: Translation.Setting('toast.cards'),
   key: 'underscript.toast.cards',
+  default: true,
+  refresh: () => onPage(''),
+  category,
 });
 
 eventManager.on(':preload:', function toasts() {