Skip to content

Commit 0f75086

Browse files
committed
fix(setting): apply id only if it does not exist
1 parent b2edff3 commit 0f75086

File tree

2 files changed

+7
-4
lines changed

2 files changed

+7
-4
lines changed

src/utils/settings/index.js

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -105,9 +105,11 @@ function createSetting(setting = defaultSetting) {
105105
removeSetting(setting, el);
106106
},
107107
}));
108-
el.attr({
109-
id: key,
110-
});
108+
if (!el.find(`#${key.replaceAll('.', '\\.')}`).length) {
109+
el.attr({
110+
id: key,
111+
});
112+
}
111113

112114
const label = $(`<label for="${key}">`).html(setting.name);
113115
const labelPlacement = type.labelFirst();

src/utils/settings/types/keybind.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ export default class extends Text {
1212

1313
element(value, update, {
1414
data = {},
15+
key: id,
1516
}) {
1617
const labels = {
1718
...baseLabels,
@@ -23,7 +24,7 @@ export default class extends Text {
2324
let val = value !== 'Escape' ? value : '';
2425
let temp = getLabel(val);
2526
const ret = $('<div class="keybind-wrapper">');
26-
const input = $('<input type="text">')
27+
const input = $(`<input type="text" id="${id}">`)
2728
.val(temp)
2829
.on('focus', () => {
2930
input.val('').prop('placeholder', 'Press Any Key...');

0 commit comments

Comments
 (0)