feat: Settings:open event

Author: feildmaster

src/utils/settings/index.js

@@ -273,6 +273,7 @@ export function open(page = 'main') {
     onshown: (diag) => {
       dialog = diag;
       events.emit('open');
+      eventManager.emit('Settings:open', diag.getModalBody());
     },
     onhidden: () => {
       dialog = null;
@@ -414,9 +415,9 @@ function getCSSName(name = '', prefix = 'setting-') {
   return `${prefix}${name.replaceAll(/[^_a-zA-Z0-9-]/g, '-')}`;
 }
 
-function untilClose(key, callback, extra = '') {
+function untilClose(key, callback, ...extra) {
   events.on(key, callback);
-  events.once(['close', extra].join(' ').trim(), () => {
+  events.once(['close', ...extra].join(' ').trim(), () => {
     events.off(key, callback);
   });
 }

src/utils/settings/types/array.js

@@ -14,7 +14,7 @@ export default class ArrayType extends Text {
     return [];
   }
 
-  element(value = [], update, {
+  element(value, update, {
     key,
     container,
   }) {

src/utils/settings/types/list.js

@@ -32,7 +32,7 @@ export default class List extends ArraySetting {
     return super.encode(value.map(getValue));
   }
 
-  element(value = [], update) {
+  element(value, update) {
     // Sortable list
     const list = $('<ol>').addClass('sortedList');
     let dragged;
@@ -99,9 +99,11 @@ function getValue(item) {
   return item;
 }
 
-function getLabel(item,
+function getLabel(
+  item,
   // allow only one level of function calls
-  allowed = true) {
+  allowed = true,
+) {
   if (allowed && typeof item === 'function') {
     return getLabel(item(), false);
   }

src/utils/settings/types/slider.js

@@ -12,9 +12,9 @@ export default class Slider extends Text {
     return $('<input>')
       .attr({
         type: 'range',
-        min: data.min || '0',
-        max: data.max || '100',
-        step: data.step || '1',
+        min: data.min ?? '0',
+        max: data.max ?? '100',
+        step: data.step ?? '1',
       })
       .val(value)
       .on('change.script', (e) => update(e.target.value));