chore: linting

Author: feildmaster

.eslintrc.cjs

@@ -43,7 +43,7 @@ module.exports = {
     'no-extra-boolean-cast': 'warn',
     'import/extensions': ['error', 'ignorePackages'],
     'import/no-extraneous-dependencies': ['error', {
-      devDependencies: ['./scripts/**'],
+      devDependencies: ['./scripts/**', './test/**', '*'],
       optionalDependencies: false,
       peerDependencies: false,
       bundledDependencies: false,

src/base/home/index.layout.js

@@ -1,6 +1,7 @@
 import eventManager from '../../utils/eventManager.js';
 import * as settings from '../../utils/settings/index.js';
 import onPage from '../../utils/onPage.js';
+import { window } from '../../utils/1.variables.js';
 
 const setting = settings.register({
   name: 'Disable Game List Resizing',

src/base/library/craft/disenchant.js

@@ -254,7 +254,6 @@ onPage('Crafting', function disenchantWrapper() {
 
   function include(rarity) {
     switch (rarity) {
-      default: debugToast(`Unknown Rarity: ${rarity}`); // fallthrough
       case 'BASE':
       case 'GENERATED':
       case 'TOKEN':
@@ -263,6 +262,9 @@ onPage('Crafting', function disenchantWrapper() {
       case 'EPIC':
       case 'RARE':
       case 'COMMON': return true;
+      default:
+        debugToast(`Unknown Rarity: ${rarity}`);
+        return false;
     }
   }
 });

src/base/lobby/disconnected.js

@@ -18,11 +18,11 @@ function setup() {
 
   eventManager.on('Play:Message', (data) => {
     switch (data.action) {
-      default:
-        waiting = false;
-        return;
       case 'getLeaveQueue':
         waiting = true;
+        break;
+      default:
+        waiting = false;
     }
   });
 }

src/base/lobby/enterOnCustom.js

@@ -1,5 +1,6 @@
 import eventManager from '../../utils/eventManager.js';
 import { infoToast } from '../../utils/2.toasts.js';
+import { window } from '../../utils/1.variables.js';
 
 eventManager.on(':load:GamesList', () => {
   let toast = infoToast({

src/base/vanilla/card.append.js

@@ -1,3 +1,4 @@
+import { window } from '../../utils/1.variables.js';
 import getExtras from '../../utils/appendCardExtras.js';
 import each from '../../utils/each.js';
 import eventEmitter from '../../utils/eventEmitter.js';

src/checker.js

@@ -1,5 +1,6 @@
 // eslint-disable-next-line no-unused-vars
 function checkUnderscript(pluginName) {
+  const window = typeof unsafeWindow === 'object' ? unsafeWindow : globalThis;
   if (window.underscript) return;
 
   const key = 'underscript.required';

src/checkerV2.js

@@ -1,4 +1,4 @@
-((pluginName = 'UNKNOWN') => {
+((pluginName, window) => {
   if (window.underscript) return;
 
   const key = 'underscript.required';
@@ -31,4 +31,4 @@
   }
 
   throw new Error(`${pluginName}: UnderScript required`);
-})(this.GM_info?.script?.name);
+})(this.GM_info?.script?.name ?? 'UNKNOWN', typeof unsafeWindow === 'object' ? unsafeWindow : globalThis);

src/structures/chat.local/channel.js

@@ -13,11 +13,11 @@ export default class Channel extends Base {
 
   update(data) {
     switch (data.action) {
-      default: break;
       case 'getMessage':
       case 'getPrivateMessage':
         // TODO: Add new message
         break;
+      default: break;
     }
   }
 

src/utils/cardHelper.js

@@ -66,13 +66,13 @@ export function dustCost(r, s) {
     r = rarity(r);
   }
   switch (r) {
-    default:
     case 'DETERMINATION': return null;
     case 'LEGENDARY': return s ? 3200 : 1600;
     case 'EPIC': return s ? 1600 : 400;
     case 'RARE': return s ? 800 : 100;
     case 'COMMON': return s ? 400 : 40;
     case 'BASE': return s ? 400 : null;
+    default: return null;
   }
 }
 
@@ -84,7 +84,6 @@ export function dustGain(r, s) {
     r = rarity(r);
   }
   switch (r) {
-    default: debug(`Unknown Rarity: ${r}`); // fallthrough
     case 'TOKEN':
     case 'GENERATED': // You can't craft this, but I don't want an error
     case 'DETERMINATION': return undefined;
@@ -93,6 +92,10 @@ export function dustGain(r, s) {
     case 'RARE': return s ? 100 : 20;
     case 'COMMON': return s ? 40 : 5;
     case 'BASE': return s ? 40 : 0;
+    default: {
+      debug(`Unknown Rarity: ${r}`);
+      return undefined;
+    }
   }
 }