fix: null is not undefined

Author: feildmaster

changelog.md

@@ -1,5 +1,8 @@
 # UnderScript Changelog
 
+## Version 0.51.3 (2022-12-13)
+1. Fix appendCard data
+
 ## Version 0.51.2 (2022-10-30)
 1. Actually fix issue in all cases
 

src/base/chat/isFocused.js

@@ -1,5 +1,6 @@
 import eventManager from '../../utils/eventManager';
 
+// TODO: Is this used?
 let focused = false;
 
 export default focused;

src/base/vanilla/aprilFools.js

@@ -1,11 +1,12 @@
 import eventManager from '../../utils/eventManager';
 import * as settings from '../../utils/settings';
-import { globalSet } from '../../utils/global';
+import { global, globalSet } from '../../utils/global';
 
 const setting = settings.register({
   name: 'Disable April Fools Jokes',
   key: 'underscript.disable.fishday',
   note: 'Disables *almost* everything.',
+  hidden: () => global('fish', { throws: false }) === undefined,
   refresh: true,
 });
 if (setting.value()) {

src/structures.local/chat.js

@@ -8,6 +8,13 @@ export default class Chat {
   }
 
   update(data) {
+    switch (data.action) {
+      case 'getMessage':
+      case 'getPrivateMessage':
+        // TODO: Add new message
+        break;
+      default: break;
+    }
   }
 
   get isConnected() {

src/utils/appendCardExtras.js

@@ -6,6 +6,6 @@ const argExtractor = {
 
 export default function getExtras(key, args = []) {
   const extractor = argExtractor[key];
-  if (!extractor) return null;
+  if (!extractor) return undefined;
   return extractor(...args);
 }

src/utils/plugin.js

@@ -5,7 +5,6 @@ const registry = new Map();
 const modules = [];
 
 // TODO: RegisteredPlugin
-
 export default function Plugin(name = '') {
   // eslint-disable-next-line no-param-reassign
   name = name.trim();

src/utils/settings/index.js

@@ -324,8 +324,10 @@ export function isOpen() {
 export function value(key) {
   const setting = settingReg[key];
   const val = localStorage.getItem(key);
-  if (!val) return getDefault(setting);
-  if (setting) return setting.type.value(val);
+  if (setting) {
+    if (!val) return getDefault(setting);
+    return setting.type.value(val);
+  }
   return val;
 }