Skip to content

Commit e9c0fbd

Browse files
committed
fix(settings): no longer break if a setting fails
1 parent 9f226cb commit e9c0fbd

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

src/utils/settings/index.js

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -164,7 +164,7 @@ function getMessage(page) {
164164
return categories[name] || createCategory(name);
165165
}
166166
category();
167-
each(pageSettings, (data = defaultSetting) => {
167+
each(pageSettings, (data = defaultSetting) => wrap(() => {
168168
let element = createSetting(data);
169169
category(data.category).append(element);
170170

@@ -175,7 +175,7 @@ function getMessage(page) {
175175
element = newElement;
176176
}
177177
untilClose(data.key, refresh);
178-
});
178+
}, data.key, getLogger(data)));
179179
if (!category('N/A').html()) {
180180
category('N/A').remove();
181181
}
@@ -411,3 +411,7 @@ function untilClose(key, callback, extra = '') {
411411
events.off(key, callback);
412412
});
413413
}
414+
415+
function getLogger({ page } = defaultSetting) {
416+
return page.logger || console;
417+
}

0 commit comments

Comments
 (0)